search

chrisgreg / bloom

The opinionated extension to Phoenix core_components
https://bloom-ui.fly.dev
MIT License
348 stars 18 forks source link

Proposal: Ensure that code is formatted before publish CI #16

Closed samjowen closed 6 months ago

samjowen commented 6 months ago

Hi @chrisgreg , seeing as this is a repository that shares common goals with shadcn's library — code ownership for the users, I think it would be a good idea to ensure that the code in this repository is always formatted before publishing.

Therefore, I propose adding a CI step that looks something like this as part of the build or publish job:

      # Step: Check that the checked in code has already been formatted.
      # This step fails if something was found unformatted.
      - name: Check Formatting
        run: mix format --check-formatted

What do you think?

chrisgreg commented 6 months ago

Sounds great, spin up a PR :)

chrisgreg commented 6 months ago

Closed by https://github.com/chrisgreg/bloom/pull/18