Feature Request: Opt-out of "stage all if nothing staged" behavior

chrisgrieser / nvim-tinygit

A lightweight bundle of commands focussed on swift and streamlined git operations.

MIT License

154 stars 4 forks source link

Feature Request: Opt-out of "stage all if nothing staged" behavior #18

Closed alex35mil closed 49 minutes ago

alex35mil commented 2 hours ago

Feature Requested

In amend functions, I think I would prefer to opt-out of "stage all if nothing staged". So it would be great to have an option to do so.

Relevant Screenshot

No response

Checklist

[X] The feature would be useful to more users than just me.
[X] I have read the Non-Goals section of the README.

chrisgrieser commented 2 hours ago

I am not sure I follow how that would be useful?

amendOnlyMsg does not stage anything
amendNoEdit stages only if nothing is staged. If you do not want to stage all changes with it, you can just stage something manually, and amendNoEdit will not stage anything. The only scenario not supported by amendNoEdit is an empty amend, which kind of does not make sense.

alex35mil commented 1 hour ago

The use-case I just faced is that I thought I staged some changes that I hadn't and with forcePushIfDiverged = true I accidentally staged all, amended, and pushed everything.

I would prefer to cancel the operation with a warning that nothing is staged in this case.

chrisgrieser commented 49 minutes ago

I see, as a safety net, that makes sense.

Added stageAllIfNothingStaged options for amendNoEdit.