chrisgrieser / shimmering-obsidian

Alfred Workflow with dozens of features for controlling your Obsidian vault.
https://alfred.app/workflows/chrisgrieser/shimmering-obsidian/
MIT License
850 stars 41 forks source link

Screenshots not showing up 😞 [ISSUE] #113

Closed yarub123 closed 1 year ago

yarub123 commented 1 year ago

Feature Requested

They successfully append the image file name into obsidian but they don't show up as screenshots but rather just the file names, like so:

Relevant Screenshot

image

Checklist

chrisgrieser commented 1 year ago

fixed in the latest release: https://github.com/chrisgrieser/shimmering-obsidian/releases/tag/3.6.1

also, please submit bugs as bug reports and not as feature requests. The form may be longer, but the requested information is often necessary.

yarub123 commented 1 year ago

@chrisgrieser Yeah man I tried a few times to find the bug report section, it just wasn't popping up on my Firefox to be honest. The only thing it allowed was a feature request, hence why I wrote "[ISSUE]" in the title. Apologies for that, I just had no other way of bringing attention to this. Sorry about that. And thank you for your quick response man, much appreciated. Will support this project this week.

Peace.

Edit:

  1. These are the following images of what shows up when I try to create an issue:

    image
  2. After clicking get started, I figured maybe I'll have the option to switch issue type and go to the "Bug" label

    image
  3. Upon clicking the "choose a different type" hyperlink, it takes me back to the starting point:

    image
chrisgrieser commented 1 year ago

Oh that's weird. I'll look into it what is causing that. Thanks for letting me know!

chrisgrieser commented 1 year ago

figured it out, now the bug report form should be available again 🙂

yarub123 commented 1 year ago

@chrisgrieser Yeah that was weird, what was it? From your end maybe? Thanks for fixing the bug that allows us to use bugs hehe.

Edit: Screenshots still popping up like this brothaman:

image

Edit 2: Is it because my vault is stored in iCloud? Does it have to be local you think?

Thanks again for your due diligence.

chrisgrieser commented 1 year ago

nah, the bug report issue was because I made a type in the yaml-file configuring the bug report form, which apparently makes GitHub completely ignore it 🙈

Ok, found the issue. Indeed overlooked a case when you have configured the screenshot path (which I didn't think of, cause you could not use a bug report form, where your config would have be apparent 😅 ) Should be fixed in the latest release: https://github.com/chrisgrieser/shimmering-obsidian/releases/tag/3.6.2

yarub123 commented 1 year ago

@chrisgrieser Awesome, just double checked it and was freaked out when it didn't work at first. But IT WORKS BEAUTIFULLY. You the man Chris. Great job.

For anyone that may still have some issues after updating, MAKE SURE TO REINITIALIZE THE SETUP PROCESS AGAIN via Alfred!!

Edit: @chrisgrieser Apologies for berating you with a bunch of comments. So I guess the fix was just to make it append to the "Images" folder and also to whatever specified folder path the user chooses in their user configuration, correct?

Because that is what it is doing on my end.