search

chrisgriffith / ionic-native-mocks

Ionic Native Mocks are designed to be used as placeholders during development for the actual Ionic Native modules.
205 stars 42 forks source link

Globalization setDefaultLanguage static function #11

Closed Naxo closed 7 years ago

Naxo commented 7 years ago

Constructor with optional property not injected properly on providers if you use useClass property. Removed constructor with optional property and updated with static function to set default value before inject providers.

chrisgriffith commented 7 years ago

Although this is a good idea, the mocks need to mirror the same signatures as the Ionic Native in order for them to function correctly. I would suggest making a PR on the Ionic Native code first, then I can replicate that new parameter in the Mock