chrisgurney / obsidian-note-toolbar

Plugin for Obsidian providing a flexible way to create context-aware toolbars for your notes.
https://github.com/chrisgurney/obsidian-note-toolbar/wiki
Apache License 2.0
261 stars 7 forks source link

Some Buttons that are supposed to run commands don't work #108

Closed endlessblink closed 2 weeks ago

endlessblink commented 1 month ago

Description of the bug when I add a command for opening the next or previous daily notes, they don't work. I tried setting this command on multiple toolbars but it just doesn't work at all. It seems like the plugin doesn't "remember" this command.

Steps to reproduce

  1. not sure what triggered it.

Expected behavior Run the command when pressing the button.

Screenshots (if you think it will help) Video or a GIF would be appreciated.

Debug info: Run "Show debug info" in Obsidian and paste it here (recommended). Alternately, fill out the sections below.

Plugin, Theme links, and CSS snippets (if applicable): Plugins, themes, and CSS snippets can affect the display of the toolbar. Include any being used here to help diagnose display issues.

Desktop environment:

Mobile environment (if applicable to the issue):

Additional context Add any other context about the problem here.

chrisgurney commented 1 month ago

@endlessblink Thanks for filing the report.

Can you please try upgrading to 1.9.8 and try again?

If that doesn't help:

chrisgurney commented 1 month ago

@endlessblink Have you been able to give 1.9.8 or later a go, to see if this corrected your problem? Thanks!

endlessblink commented 1 month ago

Hi, thanks for the reply. Yes, I tried to update the new version and run this but it still doesn't work. but it seems like it's a general bug throughout my vault and not only because of the plugin.

chrisgurney commented 1 month ago

Hmm, are commands not working at all?

Have you tried the sandbox vault?

swamiller commented 1 month ago

MacBook Pro, Note Toolbar Version: 1.9.12. Adding to this issue, I am trying to add a button to toggle properties using the "Note Toolbar: Toggle Properties" Command. No response after making the button. I tried the command using the Command Pallet (CMD-P), also no (noticeable) action.

swamiller commented 1 month ago

I found a contributing factor. I have a multicolumn view and CSS snippets for text-justify, wide-page, and float. I was not using float so I removed this option from cssclasses (leaving only text-justify and wide page). Commands worked after removing this unused CSS option. See https://github.com/efemkay/obsidian-modular-css-layout for more information.

chrisgurney commented 1 month ago

@swamiller Thanks so much for digging into this. That's really interesting. I'll have to look into this when I have time.

chrisgurney commented 2 weeks ago

@swamiller @endlessblink Checking in on this issue: Have you been able to make the plugin work for you since? There's a updated release now available, but I'm not sure it would impact the issues you encountered. If not, can you please let me know? Thank you!

swamiller commented 2 weeks ago

It seems my issues has been resolved. Thank you!

From: Chris Gurney @.> Date: Thursday, August 22, 2024 at 10:33 PM To: chrisgurney/obsidian-note-toolbar @.> Cc: Steve Miller @.>, Mention @.> Subject: Re: [chrisgurney/obsidian-note-toolbar] Some Buttons that are supposed to run commands don't work (Issue #108)

@swamillerhttps://github.com/swamiller @endlessblinkhttps://github.com/endlessblink Checking in on this issue: Have you been able to make the plugin work for you since? There's a updated release now available, but I'm not sure it would impact the issues you encountered. If not, can you please let me know? Thank you!

— Reply to this email directly, view it on GitHubhttps://github.com/chrisgurney/obsidian-note-toolbar/issues/108#issuecomment-2306072779, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEDUQJYWEOBE2OLDC5VOOXLZS2NRNAVCNFSM6AAAAABLN4KEMOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBWGA3TENZXHE. You are receiving this because you were mentioned.Message ID: @.***>

chrisgurney commented 2 weeks ago

@endlessblink Can you please confirm if you're still having issues?

If I don't hear from you I'll close this issue. Thanks!

endlessblink commented 2 weeks ago

Hi, the issue seems to be something with obsidian itself so it's ok to close the issue. Thanks!

On Mon, Aug 26, 2024 at 4:16 PM Chris Gurney @.***> wrote:

@endlessblink https://github.com/endlessblink Can you please confirm if you're still having issues?

If I don't hear from you I'll close this issue. Thanks!

— Reply to this email directly, view it on GitHub https://github.com/chrisgurney/obsidian-note-toolbar/issues/108#issuecomment-2310192165, or unsubscribe https://github.com/notifications/unsubscribe-auth/AI3PDUWBQ2E3NKC4M5FJUZ3ZTMTBFAVCNFSM6AAAAABLN4KEMOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJQGE4TEMJWGU . You are receiving this because you were mentioned.Message ID: @.***>

-- --

Noam Naumovsky Director, Video Editor, Motion Designer | m: 972-52-6784960 | e: @.*** | w: www.noamn.com/video-works http://www.noamn.com/video-works


https://www.instagram.com/noam_nau/ https://www.linkedin.com/in/noamnaumovsky/ https://wa.me/972526784960 http://discord.gg/fjkTqX4AwE @.***>