chrisgurney / obsidian-note-toolbar

Plugin for Obsidian providing a flexible way to context-aware toolbars for your notes.
https://github.com/chrisgurney/obsidian-note-toolbar/wiki
Apache License 2.0
152 stars 0 forks source link

Settings UI not always maintaining scroll position on changes #13

Closed chrisgurney closed 2 months ago

chrisgurney commented 2 months ago

Description of the bug

Make changes to some settings, and notice how the UI jumps back to the top of the display -- I think this happens more on mobile than desktop, but I feel like I've experienced this in both places.

Steps to reproduce

On mobile:

  1. Edit a particular toolbar's settings.
  2. Scroll down to Styles. Add or remove a style chip OR Remove a toolbar item. → Note how the modal jumps back to the top.

On desktop:

  1. In settings, move mappings up and down the list, with the keyboard. → Note how the settings window jumps back to the top.

Expected behavior

Maintain scroll position on changes.

Mobile (if applicable to the issue):

Mobile (if applicable to the issue):

Technical notes

chrisgurney commented 2 months ago

Fixed

Fixed in main, thanks to that Shell Commands code. Will be in a forthcoming beta.