search

chrisguttandin / dynamo-converters

A collection of converter functions to get good old JavaScript key/value objects into a DynamoDB friendly schema and back again.
MIT License
24 stars 3 forks source link

Remove timestamp and rename export #80

Closed chrisguttandin closed 2 years ago

chrisguttandin commented 3 years ago

This PR is intended to implement the changes discussed here: #79.

It can be tested by installing dynamo-converters like this:

npm i git://github.com/chrisguttandin/dynamo-converters.git#remove-timestamp-and-rename-export-build
chrisguttandin commented 3 years ago

@deini, no problem I didn't expect you to check it right away. I just thought it would be useful if you could double-check that the changes work for you too before we publish them. Just let me know when you got a moment to verify the update. Many thanks in advance.

chrisguttandin commented 2 years ago

Hi @deini, did you meanwhile manage to give these changes a try?

deini commented 2 years ago

@chrisguttandin I apologize, thought I had replied.

This works as expected, we've been using it for a while now. Thanks!

chrisguttandin commented 2 years ago

No problem, the same happened to me. I was using the branch with the build and almost forgot about this PR. :-)

I just published v6 which contains the changes. I'll wait a little longer before I delete the branch with the build to avoid any hiccups on your end.

deini commented 2 years ago

@chrisguttandin Bumped to v6, thanks for your consideration. 🙇

chrisguttandin commented 2 years ago

Okay, in that case I will kill the branch right away. 🧹