search

chrisguttandin / dynamo-db-local

A wrapper around Amazon's DynamoDB Local to start and stop it from Node.js.
MIT License
13 stars 5 forks source link

Fix docker port #109

Closed danballweg closed 2 years ago

danballweg commented 2 years ago

When using docker the current code maps port 8000 on localhost to the specified port in the container. This should be the other way around or it won't actually connect.

chrisguttandin commented 2 years ago

Thanks a lot for fixing this.

I guess that line needs to be changed as well to make the tests pass.

https://github.com/chrisguttandin/dynamo-db-local/blob/0b878c3ed94cbdb78c47ecb16e3ded008d76c88b/test/unit/module.js#L60

Do you mind doing this, too?

chrisguttandin commented 2 years ago

@danballweg I went ahead and merged the PR as is and added the update of the test in a separate commit: https://github.com/chrisguttandin/dynamo-db-local/commit/392699550ffcc0b60e99141db599cddc62dc640c.

Thanks again for fixing this.