chrisguttandin / extendable-media-recorder

An extendable drop-in replacement for the native MediaRecorder.
MIT License
258 stars 13 forks source link

add requestData() to MediaRecorder #684

Open tscritch opened 4 months ago

tscritch commented 4 months ago

Closes #679

Simple passthrough like the other MediaRecorder functions.

If there's any reason to not do this or anything you'd like me to add let me know!

chrisguttandin commented 4 months ago

Hi @tscritch, thanks for your contribution.

Unfortunately it won't work before some other things get done. The native MediaRecorder already supports requestData() but the WebmPcmMediaRecorder and WebAudioMediaRecorder do not. Implementing it for the custom recorders is a little tricky because the custom encoder interface doesn't yet support it either.

tscritch commented 4 months ago

@chrisguttandin ah I see. I figured that might be the case since it wasn't there already!

I'm trying to use this with katspaugh/wavesurfer.js ~which uses that to render the waveforms while recording.~ which uses that to ensure data gets captured after a pause in the recording. Not sure if there's a way around it.

I'd still be up for taking a swing if it's not too crazy since other people are interested in this being solved. I can take a deeper look in the next week. If you have any ideas on approach I'd love your expertise!