search

chrisguttandin / extendable-media-recorder

An extendable drop-in replacement for the native MediaRecorder.
MIT License
258 stars 13 forks source link

build(package): expose deregister #688

Closed lionelv-kry closed 4 months ago

lionelv-kry commented 4 months ago

Hi, deregister() is not exposed because it's never used I think my modification is non intrusive Regards, lionel

chrisguttandin commented 4 months ago

Hi @lionelv-kry, thanks a lot for your contribution. I agree that it is a good idea to use the deregister() function in the tests.

I'm curious though, your message seems to imply that this is fixing a bug that the deregister() function is not exposed. Is that correct?

lionelv-kry commented 4 months ago

Yes, the bundle.js is lacking it at the moment. You probably need a side project to test it properly. I had to prepublishOnly, then import absolute path to my own made bundle.js to have it working

chrisguttandin commented 4 months ago

That's strange. Are you using the latest version? It's definitely exported in bundle.js.

https://npmfs.com/package/extendable-media-recorder/9.2.0/build/es5/bundle.js#L1235

lionelv-kry commented 4 months ago

turns out I had version 9.1.13 in my dependencies, but the latest when I built locally...

chrisguttandin commented 4 months ago

Okay, good to know. Thanks a lot for your contribution. I actually revealed a bug in deregister().