Renamed the tempo quarter micro seconds duration to its proper name.

chrisguttandin / midi-json-parser-worker

The worker which is used by the midi-json-parser package.

MIT License

6 stars 1 forks source link

Renamed the tempo quarter micro seconds duration to its proper name. #330

Closed stephaneeybert closed 4 years ago

chrisguttandin commented 4 years ago

Thanks for the PR. Could you please also rename the property in the implementation and the test fixtures?

https://github.com/chrisguttandin/midi-json-parser-worker/search?q=microsecondsPerBeat&unscoped_q=microsecondsPerBeat

stephaneeybert commented 4 years ago

No trouble.

chrisguttandin commented 4 years ago

Thanks. Unfortunately there are some more fixtures which contain this event. I'm not sure why they did not show up in the GitHub search.

test/fixtures/98137.json
test/fixtures/TheEntertainer.json
test/fixtures/because.json
test/fixtures/californication.json
test/fixtures/minute_waltz.json
test/fixtures/rachmaninov3.json
test/fixtures/test.json

Could you please change those as well?

stephaneeybert commented 4 years ago

Hope I haven't missed any !