search

chrisguttandin / timingsrc

A library to synchronize a MediaElement with a TimingObject.
MIT License
32 stars 4 forks source link

Limit playback rate values #14

Closed chrisguttandin closed 2 years ago

chrisguttandin commented 2 years ago

This PR is intended to fix #13.

@AlexanderArvidsson I realized that the required changes would need to happen in a lot of files. That's mainly because of the way I wrote the type definitions (which I already regret). :-(

I thought this would be very annoying and cumbersome for you to figure out. I hope you don't mind that I already implemented all the changes.

Could you please take a look at the changes I made to check if they make sense to you?

AlexanderArvidsson commented 2 years ago

@chrisguttandin Looks good to me! Although I do not know RX, from what I can tell it seems fine. We have already finished the feature that required this change with the patch I made in the issue, but if you release this I can give it a try with the proper change and see if I run into any problems.

chrisguttandin commented 2 years ago

Okay, I've merged the chances now. Please let me know if the issue still persists for you after updating.