On Windows, when trying to configure custom open_browser_args, I noticed that default start and explorer.exe args are always forcibly prepended to the args list, no matter what is configured. I'm not sure this makes sense, as it severely restricts the available browser opening strategies for Windows users.
The change I'm proposing makes the open_browser_args behavior more consistent with the open_browser_app config, i.e. if the user provides a custom args list, assume they know what they want and use exactly what is provided.
I hope this sounds reasonable to you, but I do realize it could be a breaking change for Windows users who currently have custom explorer.exe-specific flags configured...although none of those flags seem very useful for link opening? Happy to take any feedback and suggestions.
Thanks for the great plugin!
On Windows, when trying to configure custom
open_browser_args, I noticed that defaultstartandexplorer.exeargs are always forcibly prepended to the args list, no matter what is configured. I'm not sure this makes sense, as it severely restricts the available browser opening strategies for Windows users.The change I'm proposing makes the
open_browser_argsbehavior more consistent with theopen_browser_appconfig, i.e. if the user provides a custom args list, assume they know what they want and use exactly what is provided.I hope this sounds reasonable to you, but I do realize it could be a breaking change for Windows users who currently have custom
explorer.exe-specific flags configured...although none of those flags seem very useful for link opening? Happy to take any feedback and suggestions.