search

chrishunt / desktop

A decent way to change your desktop image
https://github.com/chrishunt/desktop
MIT License
250 stars 15 forks source link

Added feature to refresh lock screen on OSX 10.10 #20

Closed hanloong closed 9 years ago

hanloong commented 9 years ago

Hi @chrishunt I had just stumbled upon your podcast (via Smashing Robots) and heard about this little gem which works like a charm.

What's this PR do?

On Mac 10.10 (Yosemite) there is a blurred version of the wallpaper set for the login/lock screen but these were not getting updated through the desktop set <filename> command. I have added a step that removes this cache file so the next time the lock/login screen are visited the png will be regenerated from the new wallpaper.

Please feel free to double check but this should not cause any backwards compatibility issues as I check for the cache files existence before removing it.

Where should the reviewer start?

Changes only in ' lib/desktop/osx/osx.rb` and corresponding test file

How should this be manually tested?

Find yourself a yosemite machine desktop set <something-great> then lock or logout the machine.

Screenshots (if appropriate)

Screen in question ![Uploading image.png . . .]()

Questions:

chrishunt commented 9 years ago

Woohoo! Thank you. Looks great to me.

I'm going to follow up with some style stuff in another PR, but I'm happy to merge this. :sparkles:

hanloong commented 9 years ago

You're most welcome. Sorry about my tests, still not that familiar with miniTest