chrishunt / desktop

A decent way to change your desktop image
https://github.com/chrishunt/desktop
MIT License
250 stars 15 forks source link

Support El Capitan #29

Closed chrishunt closed 2 years ago

chrishunt commented 8 years ago

Fixes https://github.com/chrishunt/desktop/issues/28.

We can no longer update the Mac OS X default desktop image because it's protected by the mighty El Capitan SIP. This PR makes it so that we write our desktop image to Application Support instead.

You can test this pre-release with:

$ gem update desktop --pre
chrishunt commented 8 years ago

@fullybaked, @jbrooksuk: Would you mind giving this pre-release a shot whenever you get a chance and let me know what you find?

$ gem update desktop --pre
fullybaked commented 8 years ago

Seems to be working with one exception.

If you set one of your desktop images via the System Preferences, desktop doesn't set that image to the argument passed in, but instead goes back to the system default (in this case El Capitan)

All new desktops created will have the image passed to the desktop command.

To reproduce:

You will see that the altered desktop is not the image you chose in System Prefs nor the one passed as an arg to desktop.

This could be an acceptable issue though ;) I'm happy to use the gem as is, as I rarely set the desktop image directly, preferring to use this gem

jbrooksuk commented 8 years ago

Any movement on this? :)

legomind commented 8 years ago

@chrishunt the dock restarts, but the desktop image never changes on my machine.

jbrooksuk commented 8 years ago

@chrishunt Version 10.11.3 (15D21) desktop just switched back to the default El Capitan background.