search

chrisidefix / cgal-bindings

Automatically exported from code.google.com/p/cgal-bindings
Boost Software License 1.0
0 stars 0 forks source link

[patches] py3k compatibility #45

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
Hi,

Here are some patches to improve python3 compatibility and some other 
enhancements.

Regards,

J.

Original issue reported on code.google.com by julien.s...@gmail.com on 9 Apr 2014 at 6:59

Attachments:

GoogleCodeExporter commented 9 years ago 
I integrated  2, 3, 4, 6.

Could you comment on 1, I could not find a reference in the doc.

Thanks

Original comment by sloriot...@gmail.com on 11 Apr 2014 at 6:25

GoogleCodeExporter commented 9 years ago 
Hi,

- see 
http://www.swig.org/Doc3.0/SWIGDocumentation.html
at 35.11.1 Setting the Python package

- could you explain why not 005 ?
the idea was to automate the launch of examples, useful to find regressions 
with python3
2 tests already segfault with python2

J.

Original comment by julien.s...@gmail.com on 11 Apr 2014 at 6:57

GoogleCodeExporter commented 9 years ago 
Here's another patch to load submodules at "import CGAL"

Original comment by julien.s...@gmail.com on 11 Apr 2014 at 7:42

Attachments:

GoogleCodeExporter commented 9 years ago 
I pushed 1.
About 5, I was thinking to create a decicated target for the test and make 
cmake collect automatically the targets and set the data directory.

Original comment by sloriot...@gmail.com on 11 Apr 2014 at 7:50

GoogleCodeExporter commented 9 years ago 
About 7:
I'm not a python expert.
This allows "import CGAL" to import all symbols in the current scope, right?
This is only done if I explicitly write "import CGAL"?

Original comment by sloriot...@gmail.com on 11 Apr 2014 at 7:54

GoogleCodeExporter commented 9 years ago 
-about 5: it  is already created by default by cmake with enable_testing, try 
"make test" with my patch

-about 7: yes

Original comment by julien.s...@gmail.com on 11 Apr 2014 at 8:01

GoogleCodeExporter commented 9 years ago 
7 is so great, I wanted to do this but didn't know how to do and never got time 
to do it. However, I need some time to push it because I want cmake to 
automatically fill the list of import (so that I can forget about updated the 
file).

About 5: I want cmake to collect all examples automatically without having to 
maintain the list.

Thanks a lot

Original comment by sloriot...@gmail.com on 11 Apr 2014 at 8:14

GoogleCodeExporter commented 9 years ago 
- here's an automatic version of patch 005

- windows.h redefines far, see 008

J.

Original comment by julien.s...@gmail.com on 11 Apr 2014 at 9:19

Attachments:

GoogleCodeExporter commented 9 years ago 
5 looks good. Still having an issue with data.
Do you have a better idea than passing ${CMAKE_CURRENT_SOURCE_DIR} to all 
python examples to access files in ${CMAKE_CURRENT_SOURCE_DIR}/examples/data?

Original comment by sloriot...@gmail.com on 11 Apr 2014 at 9:48

GoogleCodeExporter commented 9 years ago

Original comment by julien.s...@gmail.com on 11 Apr 2014 at 9:55

Attachments:

GoogleCodeExporter commented 9 years ago 
5 and 8 are pushed.

Thanks a lot.

Original comment by sloriot...@gmail.com on 11 Apr 2014 at 10:12

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
Hi,

Another patch to add a "make install" target to install the python module.
it installs these:
<CMAKE_INSTALL_PREFIX>/lib/pythonx.y/site-packages/CGAL/*.py
<CMAKE_INSTALL_PREFIX>/lib/pythonx.y/site-packages/CGAL/*.so
<CMAKE_INSTALL_PREFIX>/lib/*.so

To be continued for java...

J.

Original comment by julien.s...@gmail.com on 12 Apr 2014 at 10:22

Attachments: