Closed chrisimcevoy closed 1 month ago
Attention: Patch coverage is 88.25758%
with 31 lines
in your changes missing coverage. Please review.
Project coverage is 95.47%. Comparing base (
0c5b142
) to head (15072e0
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
The
SystemClock
implementation here usestime.time_ns()
, so is operating at a finer resolution (nanoseconds) than Noda Time's implementation which usesDateTime.UtcNow.Ticks
. Not that it probably makes any difference; I could well see the relatively slow execution of pure python code eating up the duration of 1 tick in the real world.This also moves /tests/testing into /pyoda_time/testing. Because the
NodaTime.Testing
library is public, and we (like Noda Time) advertiseFakeClock
as a thing that people might use. Rather than releasing a separate package, we'll just include it as a sub-package in the main project.