search

chrisjbillington / git-nautilus-icons

A nautilus Python extension to overlay icons on files in git repositories
BSD 2-Clause "Simplified" License
43 stars 4 forks source link

Icons have a super low resolution #4

Closed depau closed 6 years ago

depau commented 6 years ago

I have an HiDPI display and the icons look veeery pixelated. Is it possible to have some higher resolution icons? I can't find any SVG source file.

chrisjbillington commented 6 years ago

Ah, no, the icons are bitmaps that are generated by programatically joining together the 'subicons', which are also bitmaps (and they are pretty small bitmaps seeing as I want to be able to squish 4 'subicons' into each icon in order to show all the status information).

I've been planning on making them SVGs and programatically joining them using some SVG library, but I haven't done this yet.

chrisjbillington commented 6 years ago

I've updated the icons to be svgs. They are not the prettiest icons ever, but it should be an improvement. Could you let me know if it looks better on the high DPI display?

depau commented 6 years ago

Now they don't show up at all lol

depau commented 6 years ago

Maybe you should simply provide the bitmaps (i.e. use inkscape to raster-ize them), but also provide a 48x48 version as 24x24@2x like some themes do.

depau commented 6 years ago

Now I see why: the generated files are empty. I'll look into the generation script

depau commented 6 years ago

Screenshot 🤔🤔🤔🤔

depau commented 6 years ago

Much better now! Screenshot

Thank you!

chrisjbillington commented 6 years ago

Thanks and well spotted!

I was just copying example code from the svgutils docs that used strings with 'cm' in the size, and I changed it to 'px' and it worked...not sure why that makes any difference (worked for me!) but glad it's fixed for you!

depau commented 6 years ago

I tried to save it from Inkscape as optimized SVG and the plugin complained about an unrecognized "px" string. There it is 😅