search

chrisjenx / Calligraphy

Custom fonts in Android the easy way...
Apache License 2.0
8.59k stars 1.1k forks source link

Fix using the same string for Toolbar (sub)title #404

Closed ajarl closed 6 years ago

ajarl commented 7 years ago

Currently the same string (" ") is set on Toolbar's title and subtitle. This means that the factory is unable to determine whether a given TextView inside of a Toolbar is the title or the subtitle. The consequence is that the font is not applied properly to the subtitle.

To clarify, if you specify a titleTextAppearance and a subtitleTextAppearance, your subtitle will get its font set to the titleTextAppearance's, since it checks if the title matches first. By using unique strings, it can differentiate between the two and apply the right font to the right view.

ansman commented 7 years ago

👍

jporombka commented 7 years ago

👍