chrisjohntan / pe

0 stars 0 forks source link

Duplicate contact error message not informative #2

Open chrisjohntan opened 2 weeks ago

chrisjohntan commented 2 weeks ago

Expected: Error message would either mention which field is duplicated, or print out the duplicated person

Actual: Error message only mentions that the contact to add already exists in the address book, with no other information to help the user.

image.png

Steps to replicate:

  1. add n/test duplicate th/duplicate1 ss/undergraduate 1 r/admin e/test1@email.com
  2. add n/test duplicate th/duplicate2 ss/undergraduate 1 r/admin e/test2@email.com

Remarks: This design could cause a hindrance to users, especially those who have many pages of other contacts added (not just one as shown in the screenshot) as they would need to check through all of their contacts to rectify the error. This flaw may make the app harder to use as a CLI application.

nus-se-bot commented 1 week ago

Team's Response

We agree that our error message can be improved. We have listed this in the DG under planned enhancements as seen in example 1 under “Advanced Error Message”. In this example, we used the edit command but the same idea applies to the add command as well since it remains to be about duplicate handling. In our planned enhancements, we stated that we will inform the user on which field is duplicated so that they can have an easier time with the address book.

Developer Guide screenshot:

Screenshot 2024-11-18 190014.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]