search

chrisjsewell / ipypublish

A workflow for creating and editing publication ready scientific reports and presentations, from one or more Jupyter Notebooks, without leaving the browser!
http://ipypublish.readthedocs.io
BSD 3-Clause "New" or "Revised" License
224 stars 37 forks source link

Remove check for absolute file path in IPyPostProcessor #115

Closed phelps-sg closed 4 years ago

phelps-sg commented 5 years ago

This provides a fix for #114

chrisjsewell commented 5 years ago

Hey sorry for the late reply. This PR is a little more contencious, since there was probably a reason why I had that check in place, which I should have documented! I think it might be better though, if relative paths were converted to absolute paths (os.path.abspath) at the frontend, to avoid any ambiguity in the the rest of the conversion process, i.e. about here:

https://github.com/chrisjsewell/ipypublish/blob/71f2f919fe7d396d22f407ad550d0156ec72efcb/ipypublish/frontend/shared.py#L227

chrisjsewell commented 5 years ago

also if you could split the custom style sheet into a separate PR thanks

phelps-sg commented 4 years ago

Bear with me....Will split the pull request as soon as I figure out how to do that ;-).