chrisjsewell / pytest-notebook

A pytest plugin for regression testing and regenerating Jupyter Notebooks
https://pytest-notebook.readthedocs.io
BSD 3-Clause "New" or "Revised" License
50 stars 10 forks source link

Fix pre-commit and RTD build #42

Closed sphuber closed 1 year ago

sphuber commented 1 year ago

@chrisjsewell this fixes two issues with the CI pipeline, however, tests are still failing. Seems like some dependency down-stream got a new release which causes the diffs to be different. For some reason the md5s of images are getting changed and I have no idea who is responsible for writing this output or where it is being written:

## replaced /cells/13/outputs/0/data/image/png:
-  iVBORw0K...<snip base64, md5=f94a82072d4a539b...>
+  iVBORw0K...<snip base64, md5=d4cb03e0b7c8a788...>

## replaced /cells/14/outputs/0/data/image/jpeg:
-  /9j/4AAQ...<snip base64, md5=780504154e4118c5...>
+  /9j/4AAQ...<snip base64, md5=63dc79d972a66eab...>

## replaced /cells/15/outputs/0/data/image/png:
-  iVBORw0K...<snip base64, md5=f94a82072d4a539b...>
+  iVBORw0K...<snip base64, md5=d4cb03e0b7c8a788...>

## replaced /cells/15/outputs/3/data/image/jpeg:
-  /9j/4AAQ...<snip base64, md5=780504154e4118c5...>
+  /9j/4AAQ...<snip base64, md5=63dc79d972a66eab...>

Any ideas?

sphuber commented 1 year ago

@chrisjsewell just a quick ping. This is blocking a number of packages to release a Python 3.12 compatible version. Could you please have a look? Thanks!

chrisjsewell commented 1 year ago

all fixed cheers