search

chrisjshull / homebridge-nest

Nest plugin for HomeBridge
707 stars 111 forks source link

Thermostat Creating Separate Temperature Sensor without feature option enabled #506

Closed dmrichards26 closed 2 years ago

dmrichards26 commented 2 years ago

I have recently deployed the plugin, and while my first thermostat is integrating as expected, my second thermostat is creating an additional ambient temperature sensor, as if I am using the Thermostat.SeparateBuiltInTemperatureSensor.Enable feature option.

image

I have tried using Thermostat.SeparateBuiltInTemperatureSensor.Disable (and also tried the same option with .{SerialNumber}), but without luck. Using TempSensor.Disable removes my actual temperature sensor, but the mystery ambient sensor remains. The only way to make the unexpected temperature sensor go away is by disabling the second thermostat entirely with Thermostat.Disable.{SerialNumber}

node --version v16.14.0 homebridge --version 1.4.0

[2/9/2022, 6:56:46 AM] [Nest] initing thermostat "Living Room Thermostat": deviceId: 09AA01AC46** structureId: d9bb72f0-bba4-11e6-aede-22000b** [2/9/2022, 6:56:46 AM] [Nest] initing thermostat (P) "Garage Thermostat": deviceId: CCA7C10000** structureId: d9bb72f0-bba4-11e6-aede-22000b** [2/9/2022, 6:56:46 AM] [Nest] initing temp_sensor (P) "Garage": deviceId: 18B430CCA2** structureId: d9bb72f0-bba4-11e6-aede-22000b**

Many thanks!

adriancable commented 2 years ago

@dmrichards26 - the plug-in will create a separate HomeKit temperature sensor service if (and only if) the thermostat also has Nest Temperature Sensors associated with it. In this case, the thermostat's reference temperature will be that of the active Temperature Sensor, so we need an additional HomeKit temperature sensor service to convey the actual temperature at the thermostat.

This is clearly what's happening in your case. You have Garage Thermostat but it has a Nest Temperature Sensor associated also called Garage. So you get one HomeKit temperature sensor for the thermostat itself, and one for the Nest Temperature Sensor.

The Thermostat.SeparateBuiltInTemperatureSensor.Enable feature option creates a separate HomeKit temperature sensor even if there are no Temperature Sensors associated with the thermostat and so it really isn't necessary. This is not the case in your situation.

Closing as this is correct / as designed.