chrisjshull / homebridge-nest

Nest plugin for HomeBridge
707 stars 111 forks source link

Add support for labels on thermostats #542

Closed charlieoleary closed 2 years ago

charlieoleary commented 2 years ago

Is your feature request related to a problem? Please describe. If you have multiple Nest Thermostats the where_name is used to convey a general location (ex. 1F, 2F, 3F, etc.) and a label is used to convey the specific location (ex. Living Room, Bedroom, etc.). Currently, this project only uses where_name, so if you have multiple thermostats on a floor, they all appear as 1F instead of 1F Living Room.

Describe the solution you'd like Instead of only using where_name, append the label to it if present. For example, 1F Temperature would become 1F Living Room Temperature.

Describe alternatives you've considered I am not sure if it's still available, but the original Nest API provided a name_long value which contained the where_name and the label if present (1F (Living Room)). While I think the name looks better without the parenthesis depending on how your home is structured, this might be faster to implement if available.

Additional context I considered swapping values and use the where_name as the room and the label as the floor, but unfortunately the Nest app groups by where_name and not label and will aggregate the temperature across all devices using the where_name grouping. This means that if you swap them, you lose a lot of value and end up with a significant number of nest groups.

github-actions[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.