search

chrisjshull / homebridge-nest

Nest plugin for HomeBridge
699 stars 112 forks source link

Support Nest Detect as contact sensors #576

Closed tronikos closed 1 year ago

tronikos commented 1 year ago

Gentle ping

adriancable commented 1 year ago

Hi @tronikos - I like this, but I think you should fork the project instead.

I can't accept this PR, because as the sole project maintainer, I take on current and future responsibility for testing, managing bit rot etc. for any PR I accept, which is difficult because Nest Detects / Nest Guard are discontinued and I do not have them. I do understand that many people would like to see this feature added and have a lower bar for support than I do, so I think you having a fork is the right approach vs me accepting a PR I cannot test and continue to manage.

I'd be very happy to post a pinned issue/PR linking to your fork so people coming here would know it's available.

tronikos commented 1 year ago

What if you add me as a project maintainer? I have every nest product except thermostat and I use them daily. So if anything breaks I'd likely be the first to notice. In addition the code is pretty simple that I don't expect to cause much burden in maintaining it.