Miscellaneous testing fixes

chrisk / fakeweb

Ruby test helper for injecting fake responses to web requests

MIT License

1.09k stars 134 forks source link

Miscellaneous testing fixes #58

Closed davidcornu closed 5 years ago

davidcornu commented 7 years ago

Changes

Removes the RVM requirement to run Rake tasks
Adds test-unit to development dependencies (no longer included in recent versions of Ruby)
Removes a SimpleCov deprecation warning
Ensures allow_net_connect is correctly reset after tests to avoid cascading failures
Fixes stubs for recent versions of Ruby

davidcornu commented 7 years ago

@chrisk thanks for all the recent commits addressing all of this 😊

chrisk commented 7 years ago

Hey there @davidcornu, do you remember what issue you were running into with FakeWeb.allow_net_connect in FakeWeb's own test suite? In test/test_helper.rb there's some setup/teardown code that sets it to false and then resets it after every test. Were you seeing it leak somehow? I've merged/fixed everything else you changed except for that one, because I haven't been able to reproduce it.

Cheers!