search

chriskdon / Spots

Summer Android Game
0 stars 0 forks source link

Feature sound #39

Closed kubasub closed 9 years ago

kubasub commented 9 years ago

I completed the tasks in issue #17. Let me know if you don't like the button press sounds. I think it may be too loud/"much".

EDIT: closes #42

chriskdon commented 9 years ago

I think it sounds good but I would definitely decrease the volume on everything so it feels more subtle.

kubasub commented 9 years ago

@ChrisKdon, why did you delete the branch and close the PR?

chriskdon commented 9 years ago

Did I? That was an accident! Sorry. I was trying to clean up my branches. I hope you didn't lose anything? I assume you can just push it again from local.

On Mon Dec 22 2014 at 11:27:05 AM Jakub Subczynski notifications@github.com wrote:

@ChrisKdon https://github.com/ChrisKdon, why did you delete the branch and close the PR?

— Reply to this email directly or view it on GitHub https://github.com/ChrisKdon/DotClear/pull/39#issuecomment-67856938.

kubasub commented 9 years ago

As fate should have it, I had to delete my local repo before I noticed this and cloned the remote again so I don't either lmao. Luckily though, this PR has the commits saved so I can just reapply the changes manually. Shouldn't bee too bad, then.

chriskdon commented 9 years ago

Btw just noticed there is a "Restore Branch" button beside the deletion on github. Did you try that?

kubasub commented 9 years ago

Nice! I tried to restore it from the branches section area, but it's not listed there.

kubasub commented 9 years ago

Beauty! I think we're back. Just hold off on this until I get the volume under control.

chriskdon commented 9 years ago

This says it can't auto merge so just let me know when it's ready to be merged.

chriskdon commented 9 years ago

Can I merge it?

kubasub commented 9 years ago

@ChrisKdon, yup :)