search

chriskelly / LifeFinances

Scripts for validating retirement plans using Monte Carlo analysis.
GNU Affero General Public License v3.0
9 stars 3 forks source link

Stop simulation early if net worth hits 0 #125

Open chriskelly opened 1 year ago

chriskelly commented 1 year ago

Saves time, especially for the optimizer.

VishnuVelayuthan commented 1 year ago

Hey, I would love to help you guys with this bug. Is there a place you can point me to get me started on working to fix it?!

chriskelly commented 1 year ago

Hey @VishnuVelayuthan, this will likely involve a straightforward conditional statement in /simulator.py around line 259-262. The tricky part will be making sure not there are no unintended consequences from shortening the array lengths of a single simulation either in simulator.py or in optimizer.py. We're still working on making more robust pytesting, so in the meantime, you'll have to manually test and make sure you're seeing similar results before/after the change. If anything's unclear, feel free to schedule a chat with me and I can help walk you through.

VishnuVelayuthan commented 1 year ago

Hey @chriskelly, thanks so much for the detailed response! I signed up for a call on Thursday at 10:30am this coming week but I am also free anytime earlier as well. I'm going to start working on this issue today/weekend and keep you updated with any roadblocks I face on the way.