search

chriskite / phactory

A Database Factory for PHP Unit Tests
http://phactory.org
MIT License
140 stars 39 forks source link

Fix for strict standards warning when calling Phactory::get #9

Closed cbaclig closed 12 years ago

cbaclig commented 13 years ago

First of all, thanks for the great work so far on Phactory! I just recently started using it on a project and have found it to be very simple yet power enough to do everything that I need to do.

I was getting a strict standards warning when using Phactory::get ("Only variables should be passed by reference") and discovered that it was coming from the call to array_shift in Phactory::get. Instead, I just used an intermediate variable to hold the result to be passed to array_shift.

http://stackoverflow.com/questions/2354609/strict-standards-only-variables-should-be-passed-by-reference

andho commented 12 years ago

+1

jimbojsb commented 12 years ago

This is fixed by the namespace refactor