chrisknepper / android-messages-desktop

Android Messages as a Cross-platform Desktop App
MIT License
1.01k stars 116 forks source link

v3.1.0 not remembering dark theme enabled #217

Closed GTR8000 closed 4 years ago

GTR8000 commented 4 years ago

v3.1.0 on Win 10 x64 is not remembering the dark theme setting when closing/reopening the program. It keeps defaulting to light theme. Have to toggle the dark theme switch in settings to get back to dark theme. Tried reinstalling the software, same behavior.

whoster69 commented 4 years ago

I'm having a similar problem. v3.1.0 will switch from dark to light theme without me doing anything and I have to manually force it to go back to dark mode. Running Windows 10 x64.

Each time I load it, it is in light mode no matter what I set it to.

Dark mode worked fine before but now is broken.

vanowm commented 4 years ago

is your system set to dark theme?

whoster69 commented 4 years ago

Yes.

GTR8000 commented 4 years ago

There are two settings for Windows 10: the default Windows mode, and the default App mode. Mine are set to Windows = dark, and App = light.

Note that I've always had them set that way, and Android Messages Desktop always operated in dark mode regardless, as I had the setting within the app set to enable dark mode.

This behavior just started with v3.1.0

whoster69 commented 4 years ago

I have both set to dark mode.

gitguys commented 4 years ago

Not remembering dark mode on Mac either. The previous version remembered my dark mode setting. I don't have dark mode for the entire system with my macOS Sierra version but I want Messages to be dark nonetheless. 3.1.0 broke this and I have to toggle dark mode each time I open Messages now.

Ness199X commented 4 years ago

You will need to disable "use system dark mode setting" under preferences. Its somewhat confusing since on older versions of OSes that don't have dark modes (like MacOS High Sierra) this results in it defaulting itself to light mode. Disabling that setting will cause it to remember which mode you want.

benjaminnyc commented 4 years ago

Same problem. Upon startup, it's in light mode, even though the settings (three dots) are set to dark. You have to turn off dark, then turn it back on to reenable. Then it stays dark until the next restart of the app.

ffxsam commented 4 years ago

You will need to disable "use system dark mode setting" under preferences.

I have no such setting, neither on the desktop version nor on my Pixel 4.

gitguys commented 4 years ago

You will need to disable "use system dark mode setting" under preferences. Its somewhat confusing since on older versions of OSes that don't have dark modes (like MacOS High Sierra) this results in it defaulting itself to light mode. Disabling that setting will cause it to remember which mode you want.

I don't see that setting anywhere in Sierra. Are you talking about this Messages app's preferences or something else? Only settings I see in this Messages app is "Dark Theme" with a toggle and the ability to enable and disable the dark theme within the 3 dot menu. Screen Shot 2019-12-02 at 2 20 10 PM Screen Shot 2019-12-02 at 2 19 49 PM

benjaminnyc commented 4 years ago

I found it in the Settings menu (press Alt to show menubar). However, it seems to have no effect on the problem. I'm now on today's update 3.1.0-2.

ffxsam commented 4 years ago

Aha! I didn't think to even look there. Thanks, that did the trick for me.

image
benjaminnyc commented 4 years ago

For the record, I am running on Manjaro Linux. I have a system dark theme, but no sure what my setting should be with Linux.

gitguys commented 4 years ago

Aha! I didn't think to even look there. Thanks, that did the trick for me.

image

Worked for me as well in Sierra.

chrisknepper commented 4 years ago

Hey all, sorry for this confusion--I put a note that this supersedes the setting in the Google menu in the changelog, but I should have been clearer about un-setting the Google setting. I will add a note to the readme. I'm not sure if it's possible to disable the Google setting from the Electron side.

To be clear, for correct dark/light automatic switching, the Google setting "Dark theme" on desktop should be unchecked and "Use System Dark Mode Setting" under the application settings menu should be checked.

As far as Linux support, Electron seems to support dark/light inheritance from the operating system, but the docs do not seem to mention which (if any) distros/window managers/desktop environments are actually supported.

benjaminnyc commented 4 years ago

Thanks @chrisknepper. In Manjaro-Gnome, it seems I need to keep both settings (Google's and yours) on dark theme to have dark theme on relaunch.

JigoloPete21 commented 4 years ago

You will need to disable "use system dark mode setting" under preferences. Its somewhat confusing since on older versions of OSes that don't have dark modes (like MacOS High Sierra) this results in it defaulting itself to light mode. Disabling that setting will cause it to remember which mode you want.

JigoloPete21 commented 4 years ago

I can confirm this steps works on OSX High Sierra 10.13.6 perfectly! Thanks! Indeed that is VERY confusing.

GTR8000 commented 4 years ago

This issue seems to have rectified itself.

BStenfors9119 commented 4 years ago

I am using Linux Mint 19.3 Tricia.

To fix this, I unticked the "Settings" -> "Use System Dark Mode Setting" and now the application itself remembers my dark mode setting so when I restart the app it stays in "Dark Mode".

Glad I finally read through this thread because it was driving me insane, lol.

Thanks for this app by the way, it's a life saver for me after I switched from Hangouts to Messages full time.

Kudos to the contributors!! Bryan

rvcjew commented 4 years ago

You will need to disable "use system dark mode setting" under preferences. Its somewhat confusing since on older versions of OSes that don't have dark modes (like MacOS High Sierra) this results in it defaulting itself to light mode. Disabling that setting will cause it to remember which mode you want.

Thanks for this tip, use light mode on apps but not ui.