search

chrisknepper / android-messages-desktop

Android Messages as a Cross-platform Desktop App
MIT License
1.01k stars 116 forks source link

JavaScript error: Incorrect url to image #243

Open aidenmadaffri opened 4 years ago

aidenmadaffri commented 4 years ago

image It looks like this image is pointing to https://www.gstatic.com/-images/branding/product/2x/messages_96dp.png but that '-' is screwing up the web address. I would add a pull request to fix this, but I can't find where in the code that this url is getting requested.

jjgalvez commented 4 years ago

just wanted to add a me too, I just started getting the same error. Happens every time I get a text message

OrangeDrangon commented 4 years ago

Same here

OrangeDrangon commented 4 years ago

I have cloned the repo and built the development version and cannot get the bug to happen again in the debugger. Does anyone have steps to reproduce as I cannot replicate it outside of the particular arch build I have.

philomena420 commented 4 years ago

Exact same issue as image above when installed from AUR. Occurs each time a I get a new message notification.

OrangeDrangon commented 4 years ago

I solved it. I will make a fork and PR I do not know if it will be merged but I can include steps to install it manually.

It was a problem with the message notification as you pointed out. I realized what exactly was causing it after re-implementing the whole thing in my own project using this one as reference.

Kandelai commented 4 years ago

@OrangeDrangon So I am using your fork now, and unfortunately whatever you did, took away the app sitting in the system tray under KDE Manjaro Linux, which prevents any pop-up notifications. I can run the app in a minimized capacity, but the original system tray worked best.

OrangeDrangon commented 4 years ago

Lets direct issues to the fork as I do not want to pollute this repo. That is strange considering I develop in KDE Manjaro and that is the only os the fork has been tested for. If you would not mind opening an issue with some more details I would be happy to help.

Kandelai commented 4 years ago

@OrangeDrangon I would be glad to open an issue on your fork, but I am not seeing the "Issues" tab or any way to create one. Do you have this disabled on your gitHub page, or am I just not looking in the right spot?

OrangeDrangon commented 4 years ago

It should be there sorry about that. I do not know how it got disabled.