search

chrisknewman / tusas

Other
16 stars 6 forks source link

Add the fullycoupled model to the summit branch #141

Closed stvdwtt closed 2 years ago

stvdwtt commented 2 years ago

Here's the updated version of the summit branch that I used for the AM Bench simulations. I've verified the fullycoupled results against the fullycoupled testcase on master. The farzadi, heat, and goldak test cases all run, but I haven't verified the results.

I'll update this thread as I check for regressions, and if everything looks good I'll remove the "WIP".

stvdwtt commented 2 years ago

@chrisknewman, this is ready to merge.

I added regression tests named FarzadiSphere and Goldak to test the farzadi3d and goldak testcases, respectively. These tests don't run with CTest, but can be run manually on Summit with the run_test_summit scripts. I also created a run_test_summit script for HeatHexT. I don't yet have a regression test for fullycoupled, I'll add that in a future PR. The current code reproduces the master-based version. Since this summit-based version is that one I'm actively working with now, I think it is fair to call this the reference version.

stvdwtt commented 2 years ago

Since I added it for the master-based fullycoupled branch, I also just added the FullyCoupled test to this branch. I've confirmed that the test results between the two branches match.