chriskonnertz / DeepLy

PHP client for the DeepL.com translation API (unofficial)
MIT License
229 stars 49 forks source link

API Key #13

Closed chriskonnertz closed 2 years ago

chriskonnertz commented 6 years ago

The DeepL docs says that there will be an API key. DeepLy 2 will support the usage of this API key.

Development will happen on this branch: https://github.com/chriskonnertz/DeepLy/tree/2.0

glemmal commented 6 years ago

is this enhancement already mergable? I noticed that deepl now started the premium program on their website. Thank you very much for your client!

chriskonnertz commented 6 years ago

Hello, unfortunaetly this branch is not ready to be merged.

I will try to finish it as soon as possible. However, I still try to figure out if there is a way to avoid the costs of the premium program since this is a free open source library that does not create any revenue...

scribnermj commented 6 years ago

I didn't see anything about a transition from public access to premium service on their web site. Did I miss it?

chriskonnertz commented 6 years ago

"DeepL Translator" also know as their online translation tool still is non-premium.

However, they recently released "DeepL Pro" which includes access to their API via an API authentication key. "DeepL Pro" is a premium service.

Officially the API never has been meant to be accessible for the public. However, since "DeepL Translator" uses their API and thus makes API calls from a client it is possible to use there API without an API key.

chriskonnertz commented 6 years ago

I have sent them a mail. I asked them if they offer any support for open source development. I do want to avoid paying 20 € to get access to their API to develop a non profit software. I will wait until they answer before taking further action.

scribnermj commented 6 years ago

It seems a bit premature to start charging for the service right now. Both Bing and Google offer better service with many more languages and very competitive pricing as far as I can tell.

chriskonnertz commented 6 years ago

I do not judge. However, I assume unlike Google and MS they really need to make money with that service.

scribnermj commented 6 years ago

I get it too. Not judging. Just expressing my view on it. It's pretty handy for my needs. I'll be disappointed if and when I get shut out .

chriskonnertz commented 6 years ago

@glemmal

is this enhancement already mergable?

PS:

The branch is not mergable, however, I believe it might work. I have not DeepL Pro access, therefore I have no API key and cannot test the branch. However, it might work. Feel free to test it :P

glemmal commented 6 years ago

@chriskonnertz sorry for the late reply. I already tested the branch and it doesn't seem to work that way. It only accepts the api key via query param. i have a quick and dirty working example that looks like this: image Anyways i will come up with a working PR soon :)

chriskonnertz commented 6 years ago

I already tested the branch and it doesn't seem to work that way

Argh. Sad.

Anyways i will come up with a working PR soon :)

That would be great!!

Did you subscribe to DeepL Pro to test your code?

nemeth-it commented 6 years ago

Hello @chriskonnertz,

I would suggest to think about again, to implement the API into the workflow. DeepL has changed the price-model again to much more fair conditions. ( starts with € 5.99 )

https://www.deepl.com/pro.html

I would like to add a custom api-key to the workflow, because the starter-account is that what firts best for private-usage and feels also fair. I'm a huge fan of Linguee and now also for DeepL, so I would like to support them with a fair usage and price.

They really gave and delivered us a good service, which should be honoured.

chriskonnertz commented 6 years ago

Hello @inovek ,

you are right and in general I do want to support DeepL pro. It's just a question of time.

chriskonnertz commented 2 years ago

Finally done, only took 4 years 💥