chriskyfung / amp-affiliately-jekyll-theme

An AMP-Ready Jekyll Blog Theme
https://chriskyfung.github.io/amp-affiliately-jekyll-theme/
MIT License
18 stars 11 forks source link

🩹 fix (amp): remove unused ‘amp-link-rewriter’ extension from AMP pages #52

Closed chriskyfung closed 8 months ago

chriskyfung commented 8 months ago

Problem

AMP validation fails for all pages that use the ‘amp-link-rewriter’ extension, which is no longer needed after dropping the Viglink integration in PR #45.

Actual Behavior

Expected behavior

AMP validation should pass for all pages without any errors or warnings related to the ‘amp-link-rewriter’ extension.

Steps to reproduce

  1. Run npm test in the terminal to run the AMP validator.
  2. Observe the error messages for each page that uses the ‘amp-link-rewriter’ extension, such as:

     FAIL: blog\example\index.html
     line 674, col 0: The extension 'amp-link-rewriter' was found on this page, but is unused. Please remove this extension. (see undefined)

Possible solution

Remove the ‘amp-link-rewriter’ extension from the pages that use it, and update the tests accordingly.

Additional context

This issue is related to PR #45, which removed the Viglink integration that required the ‘amp-link-rewriter’ extension.