duesenklipper commented 11 years ago

When going into the tweet details view and there to the discussion tab, the current version of TweetLanes in the play store displays only "No content loaded at this time." Refreshing that view displays "Loading...", but nothing ever happens. In previous versions this worked.

jamesduffy commented 11 years ago

Thanks, I can confirm this. Might have something to do with Twitter API v1.1.

chrislacy commented 11 years ago

Yes, this will be a v1.1 API issue.

Chris Lacy @chrismlacy (https://twitter.com/chrismlacy) / +Chris Lacy (https://plus.google.com/104649936579980037256/)

On Wednesday, February 20, 2013 at 5:59 PM, James Duffy wrote:

Thanks, I can confirm this. Might have something to do with Twitter API v1.1.

— Reply to this email directly or view it on GitHub (https://github.com/chrislacy/TweetLanes/issues/19#issuecomment-13820098).

Fammy commented 11 years ago

Ok, we may have a problem. The api endpoint, /1/related_results/show does not exist in the 1.1 api. This is intention on the part of twitter and they do not have a plan to add it, despite the entire development community begging.

Options:

Short term, use the 1.0 api. Will break soon.
Long term: remove the feature
Long term: work-arounds involve loading replies to a tweet, then loading replies to the replies, in a loop. Massive number of API calls potentially. Slow, non-ideal

What do you all think we should do?

jamesduffy commented 11 years ago

I think we should be focusing on implementing Twitter's API v1.1, but without trying to "hack" stuff together. Could we change the screen to only show replies one-layer deep?

Then possibly merge #11 and show replies and retweets below the tweet rather than with separate tabs. Thoughts?

(Looking at App.net I could not find a API call similar to Twitter's old call. Maybe I just didn't find it.)

Thermi commented 11 years ago

I'm for implementing the work-around, because it fixes the problem. All the other ways of doing it seem wrong to me. As soon as Twitter "fixes" the api, this is the only way.

jamesduffy commented 11 years ago

13 and #14 appear to be fixed on the develop channel and #19 works until we can come up with a better solution. I have tried the following with the updated twitter4j:

tweet and reply
follow and unfollow
favoriting and unfavoriting tweets
retweeting and un-retweeting
sending direct messages
refreshing the timelines
viewing discussions works, but not ideal
can not see any retweets when I know there are some on the tweet details page (not sure what else there is)

Fammy commented 11 years ago

@jamesduffy That last bullet point, is that an issue that needs looking into?

Are we ready for a beta build off develop?

jamesduffy commented 11 years ago

I think we are ready.

On Thursday, February 21, 2013, Jason Famularo wrote:

@jamesduffy https://github.com/jamesduffy That last bullet point, is that an issue that needs looking into?

Are we ready for a beta build off develop?

— Reply to this email directly or view it on GitHubhttps://github.com/chrislacy/TweetLanes/issues/19#issuecomment-13893323.

chrislacy commented 11 years ago

Question: should the develop branch by sync'd with master?

I think it makes sense to make the builds from master.

Chris Lacy @chrismlacy (https://twitter.com/chrismlacy) / +Chris Lacy (https://plus.google.com/104649936579980037256/)

On Friday, February 22, 2013 at 2:31 AM, James Duffy wrote:

I think we are ready.

On Thursday, February 21, 2013, Jason Famularo wrote:

@jamesduffy https://github.com/jamesduffy That last bullet point, is
that an issue that needs looking into?

Are we ready for a beta build off develop?

—
Reply to this email directly or view it on GitHubhttps://github.com/chrislacy/TweetLanes/issues/19#issuecomment-13893323.

— Reply to this email directly or view it on GitHub (https://github.com/chrislacy/TweetLanes/issues/19#issuecomment-13898188).

mohitd commented 11 years ago

Following the git-flow ideology, the master branch should only have the latest stable build and the develop branch should have the latest nightly build. Beta testing usually goes on a release branch. Then when we're done with beta testing, calling "git flow release finish xxxx" will merge the commits into develop and master and then tag master with a version name.

jamesduffy commented 11 years ago

I really think we should push the bug fixes we have already to master and publish to the play store. Users are not happy about lists not working. I don't believe there is any issues with the current develop branch that would stop us.

mohitd commented 11 years ago

I'll create a release branch within the hour (as soon as I finish formatting the code) and push version 0.72.1

On Fri, Feb 22, 2013 at 6:01 PM, James Duffy notifications@github.comwrote:

I really think we should push the bug fixes we have already to master and publish to the play store. Users are not happy about lists not working. I don't believe there is any issues with the current develop branch that would stop us.

— Reply to this email directly or view it on GitHubhttps://github.com/chrislacy/TweetLanes/issues/19#issuecomment-13978430.

Yours Sincerely,

Mohit Deshpande Mobile Platform Developer

jamesduffy commented 11 years ago

Thanks, you're awesome.

Fammy commented 11 years ago

I just tried setting up a new install and it crashes on the exit of the tutorial. Can you all repro? Works after you relaunch.

mohitd commented 11 years ago

My build did not crash. I'll push the cleaned up code to develop in a couple of minutes.

jamesduffy commented 11 years ago

I am getting a twitter over capacity right now and can't login.. I will let you know once I can get to the tutorial.

jamesduffy commented 11 years ago

No crashes moving from the tutorial to the app on my N7.

mohitd commented 11 years ago

I'm not getting any crashes either. I just created a release branch. Let me know of any bugs we can fix before I finish the release.

mohitd commented 11 years ago

Alright I'm going to finish the release. If there is a bug there, let me know and I'll create a hotfix for you to commit the patch and I'll finish the hotfix (which would merge back into master for a stable release and develop)

chrislacy commented 11 years ago

Sorry for the delay replying. Between the Action Launcher release and feeling sick (which I'm still not over) I've been largely MIA the last few days.

Is the code ready for me to create an RC with?

Chris Lacy @chrismlacy (https://twitter.com/chrismlacy) / +Chris Lacy (https://plus.google.com/104649936579980037256/)

On Saturday, February 23, 2013 at 10:07 AM, Mohit Deshpande wrote:

Alright I'm going to finish the release. If there is a bug there, let me know and I'll create a hotfix for you to commit the patch and I'll finish the hotfix (which would merge back into master for a stable release and develop)

— Reply to this email directly or view it on GitHub (https://github.com/chrislacy/TweetLanes/issues/19#issuecomment-13980628).

Fammy commented 11 years ago

Yes, ask @all0c which branch to use.

chrislacy commented 11 years ago

I don't see such a branch. Or am I missing something?

Chris Lacy @chrismlacy (https://twitter.com/chrismlacy) / +Chris Lacy (https://plus.google.com/104649936579980037256/)

On Tuesday, February 26, 2013 at 6:40 AM, Jason Famularo wrote:

Yes, use the release branch @all0c (https://github.com/all0c) created.

— Reply to this email directly or view it on GitHub (https://github.com/chrislacy/TweetLanes/issues/19#issuecomment-14074150).

Fammy commented 11 years ago

I edited my comment. I'm not sure what he was doing.

jamesduffy commented 11 years ago

I tried to build an unsigned application package and I got this error: [2013-02-25 13:42:35 - TweetLanes] Proguard returned with error code 1. See console [2013-02-25 13:42:35 - TweetLanes] Error: Can't read [C:\Users\jamesduffy\Documents\GitHub\TweetLanes\android\client\Users\chrislacy\android-sdk-macosx\platforms\android-14\android.jar] (No such file or directory)

mohitd commented 11 years ago

Sorry about that, SourceTree messed up my local repo a bit then decided to push. I think the release branch merged back into develop. I fixed it so that it doesn't happen again. Sorry.

On Mon, Feb 25, 2013 at 4:47 PM, James Duffy notifications@github.comwrote:

I tried to build an unsigned application package and I got this error: [2013-02-25 13:42:35 - TweetLanes] Proguard returned with error code 1. See console [2013-02-25 13:42:35 - TweetLanes] Error: Can't read [C:\Users\jamesduffy\Documents\GitHub\TweetLanes\android\client\Users\chrislacy\android-sdk-macosx\platforms\android-14\android.jar](No such file or directory)

— Reply to this email directly or view it on GitHubhttps://github.com/chrislacy/TweetLanes/issues/19#issuecomment-14077932.

Yours Sincerely,

Mohit Deshpande Mobile Platform Developer

chrislacy / TweetLanes

Discussion doesn't load #19

13 and #14 appear to be fixed on the develop channel and #19 works until we can come up with a better solution. I have tried the following with the updated twitter4j: