chrislacy / TweetLanes

Tweet Lanes for Android
Other
768 stars 278 forks source link

Crash on tapping the media/image preview #431

Closed mbutz closed 6 years ago

mbutz commented 6 years ago

Best twitter client I have found so far! Thanks for the good work. What I especially like is the fact that even after a refresh you can continue reading the tweets where you started.

Unfortunately I experience reproducable crashes whenever I try to tap on the media preview image (which is a great feature!).

Don't know if that has been reported yet. But there is a (german) review at Google Play Store moaning the same issue.

mcr42 commented 6 years ago

The problem is in GestureImageView.java:623, where GestureImageView.onCreateDrawableState(...) throws an UnsupportedOperationException: Not supported if mstrict is true. I'm not certain whether this would be correct, but skipping this check and just returning super.onCreateDrawableState(...) makes it work in the Emulator.

mbutz commented 6 years ago

Ok, thanks a lot. I guess I will have to install the latest version from Github, right? Havn't done that before, always used Goggle Play. But will try as soon as I have time to... Thanks again for looking into that.

mcr42 commented 6 years ago

No, you don't. I received update 1.5.1 yesterday from Google Play around the time of your comment, and it contains this fix. No more crashes on my device... ;-)

mbutz commented 6 years ago

Great! Updated via app store and also got rid of the crashes. Gratefully closing this issue.