chrisle / seer.js

An all-in-one toolbox made for SEOs
200 stars 50 forks source link

Fixing sorting bug in ga code. #1

Closed SebastianEdwards closed 11 years ago

SebastianEdwards commented 11 years ago

Just a quick patch to get analytics sorting working.

I've also removed the behaviour where you were prefixing all sort values with an '-' to automatically reverse the sort direction. I feel that allowing access to both ASC and DESC ordering outweighs the advantage of being able to leave a single character out of the sort parameter.

PS. Big thanks to you for open sourcing this project. It is gold! Looking forward to adding more API integrations to it in the future.

chrisle commented 11 years ago

Huge thank you!!