search

chrislee0419 / EnhancedSearchAndFilters

A Beat Saber mod that adds auto-refreshing search and song filtering capability
MIT License
25 stars 3 forks source link

Filter reverts to none #5

Closed IonEwe closed 4 years ago

IonEwe commented 5 years ago

Enhanced Search and Filters v1.6.1 - filter other seems to drop after after a level / map is played.

chrislee0419 commented 5 years ago

Hey IonEwe, thanks for reporting this.

Do you have SongBrowser installed? Or are you only using my mod?

IonEwe commented 5 years ago

song browser v5.5.2 installed. the filter i've seen this with is mostly with the filter "have not played" songs. the filter is not cleared from the selection it just needs to be re-applied. Very likely this is related to the updated refresh, because if the song has an additional selection (say easy, normal) and the only level that is left is filtered out, it will refresh the list exclude the song, have the cursor at the top of the list and the filter will still be applied.

On Tue, Nov 19, 2019 at 1:45 AM Chris notifications@github.com wrote:

Hey IonEwe, thanks for reporting this.

Do you have SongBrowser installed? Or are you only using my mod?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/chrislee0419/EnhancedSearchAndFilters/issues/5?email_source=notifications&email_token=ACLU67UMF2J42QSPBK2NJKLQUODPNA5CNFSM4JOWZQKKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEENBXCY#issuecomment-555359115, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACLU67RY5QFRLO33CKHV5FDQUODPNANCNFSM4JOWZQKA .

chrislee0419 commented 4 years ago

I've tried to reproduce the problem on my machine, but I'm not getting any issues. Completing a level did not cancel the filter after getting back to the menus.

Just to be sure, the problem is that completing a level (regardless of pass/fail I'm guessing) would cause the filter to reset from 'Other' to 'None'. Is that correct?

Also, if possible, can you outline a series of steps that would consistently produce the issue? If you can reproduce the issue consistently, it would also be helpful if you provide me with the log file. You can find the log file at "Beat Saber/Logs/_latest.txt".

IonEwe commented 4 years ago

other to none <- correct. i will make a VOD of it and give a link. and dig up the log and send as well.

On Tue, Nov 19, 2019 at 11:25 PM Chris notifications@github.com wrote:

I've tried to reproduce the problem on my machine, but I'm not getting any issues. Completing a level did not cancel the filter after getting back to the menus.

Just to be sure, the problem is that completing a level (regardless of pass/fail I'm guessing) would cause the filter to reset from 'Other' to 'None'. Is that correct?

Also, if possible, can you outline a series of steps that would consistently produce the issue? If you can reproduce the issue consistently, it would also be helpful if you provide me with the log file. You can find the log file at "Beat Saber/Logs/_latest.txt".

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/chrislee0419/EnhancedSearchAndFilters/issues/5?email_source=notifications&email_token=ACLU67WHRYX22CDMUTNHVYDQUS35FA5CNFSM4JOWZQKKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEQVETI#issuecomment-555831885, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACLU67WX7RLLPECDETWSEYDQUS35FANCNFSM4JOWZQKA .

IonEwe commented 4 years ago

here is the vod https://www.twitch.tv/videos/510917895 with many different use cases. There maybe a lib problem given that there are other issues. 1) song completes and doesn't give the play option until another song is selected and then play is an option. 2) no score updates where uploading at the end of the stream.

On Wed, Nov 20, 2019 at 8:39 AM Paul Hardin paul.hardin@makeitlabs.com wrote:

other to none <- correct. i will make a VOD of it and give a link. and dig up the log and send as well.

On Tue, Nov 19, 2019 at 11:25 PM Chris notifications@github.com wrote:

I've tried to reproduce the problem on my machine, but I'm not getting any issues. Completing a level did not cancel the filter after getting back to the menus.

Just to be sure, the problem is that completing a level (regardless of pass/fail I'm guessing) would cause the filter to reset from 'Other' to 'None'. Is that correct?

Also, if possible, can you outline a series of steps that would consistently produce the issue? If you can reproduce the issue consistently, it would also be helpful if you provide me with the log file. You can find the log file at "Beat Saber/Logs/_latest.txt".

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/chrislee0419/EnhancedSearchAndFilters/issues/5?email_source=notifications&email_token=ACLU67WHRYX22CDMUTNHVYDQUS35FA5CNFSM4JOWZQKKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEQVETI#issuecomment-555831885, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACLU67WX7RLLPECDETWSEYDQUS35FANCNFSM4JOWZQKA .

chrislee0419 commented 4 years ago

I think I found out where the problem was. Can you download this version and see if it fixes it on your end?

EnhancedSearchAndFilters.zip

chrislee0419 commented 4 years ago

Also, about the play button and score submission/update problems, I believe all of that stuff should be handled by ScoreSaber, which isn't open source.

If those problems continue for you and are consistent, it might be worthwhile to report it to Umbra about it.

IonEwe commented 4 years ago

seems to be fixed. didn't test it as many use cases, but i will. Other issues not impacted.

On Wed, Nov 20, 2019 at 7:49 PM Chris notifications@github.com wrote:

Also, about the play button and score submission/update problems, I believe all of that stuff should be handled by ScoreSaber, which isn't open source.

If those problems continue for you and are consistent, it might be worthwhile to report it to Umbra about it.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/chrislee0419/EnhancedSearchAndFilters/issues/5?email_source=notifications&email_token=ACLU67VLKK46PQKW3ZSYUIDQUXLJZA5CNFSM4JOWZQKKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEXFLAY#issuecomment-556684675, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACLU67XYADQEZCHFFJRIWC3QUXLJZANCNFSM4JOWZQKA .

chrislee0419 commented 4 years ago

Sure thing, just let me know if this specific issue is fixed, so I can close this. If you are having other issues that are not related to this one but are relevant to this mod, make another post for me to keep track of it.

And as said before, if you are still having issues with the play button and score submission, you might want to post it in the ScoreSaber discord, under the #bug-reports channel.

Thanks again for reporting this issue!

chrislee0419 commented 4 years ago

Since there hasn't been a response, I'm assuming the fix worked. Because of that, I'm closing this issue and considering it finished.

IonEwe commented 4 years ago

yes... closed

On Thu, Nov 28, 2019 at 5:45 PM Chris notifications@github.com wrote:

Closed #5 https://github.com/chrislee0419/EnhancedSearchAndFilters/issues/5.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/chrislee0419/EnhancedSearchAndFilters/issues/5?email_source=notifications&email_token=ACLU67UIWP7OKVZCT2HHGADQWBCXJA5CNFSM4JOWZQKKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOVFDM6SY#event-2839990091, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACLU67RC7IKCRVN3GKKVF6LQWBCXJANCNFSM4JOWZQKA .