Calculation of % of available balance asset

[gilmillasseau]

Reopening this discussion https://github.com/chrisleekr/binance-trading-bot/issues/12#issuecomment-826778785_

Things to discuss:

• Find out whats wrong the the calculation of the 2nd purchase
• If this configuration makes sense globally

[chrisleekr]

Note that this issue is related with PR #77

And I have mentioned the reason in #12 for the issue.

To re-iterating the issue, let me explain further about the issue.

Let say, I am monitoring two coins - BTCUSDT, ETHUSDT, LTCUSDT

And I have configured 50% as the maximum purchase amount.

Assume I have 100 USDT at the moment

• First purchase for BTCUSDT
  • The bot will buy 50 USDT worth of BTC, now I have 50 USDT left in my balance
• Second purchase for ETHUSDT
  • The bot will buy 25 USDT worth of ETH, now I have 25 USDT left in my balance
• Third purchase for LTCUSDT
  • The bot will buy 12.5 USDT worth of LTC, which is not making sense to buy this much amount of coin.

So as you can see each purchase amount is not consistent. That is why I decide to use a static maximum purchase amount.

However, you are having an issue because I removed the maximum purchase amount from the global configuration for this improvement #104

You can still configure the maximum purchase amount in the symbol configuration. I couldn't think of a better way to set the maximum purchase amount in the global configuration.

[gilmillasseau]

Very well explained, thanks.

This is tricky to solve indeed, probably if we had a concept of Portfolio Asset (available + invested) could solve the issue but we don't have that data out of the box I assume.

Assuming we had that data do you think it could potentially solve the issue?

Legend: PA - portfolio asset (available + invested) AA - available asset (available only)

Assume : Current balance: 100USDT Global config for max purchase: 20%

First purchase for BTCUSDT

• The bot will buy 20 USDT worth of BTC (20% of PA), now I have 80 USDT available asset (AA) and 100 portfolio asset (PA)

Second purchase for ETHUSDT

• The bot will still buy 20 USDT (20% of the PA) worth of ETH, now I have 60 USDT (AA) and still 100 USDT (PA)

Imagine bot sells first purchase and I have 4% profit (PA: 104 USDT, AA: 84 USDT)

Third purchase for BTCUSDT

• The bot will buy 20,8 USDT worth of BTC (20% of 104USDT PA), now I have 63,2 USDT available asset (AA) and 104 portfolio asset (PA)

Not sure all calculations are correct but I think you get the idea.

[chrisleekr]

That maybe works when you only use single FIAT. Actually, it will be very complicated to check that even single FIAT.

Imagine you have BTC/BNB/USDT/BUSD as quote assets. In addition, you will also do some manual orders as well.

It will be impossible to get the total portfolio assets to calculate.

[gilmillasseau]

Yeah, the cost benefit of doing it probably is not worth it for now.

I think if we have an option to override the default fallback value (100) for now would be great. Every time I restart the service I need to individually put the maxPurchaseAmount for each pair.

[chrisleekr]

@gilmillasseau

Ehhhh? Are you saying, every time you restart maxPurchaseAmount is reset? That should not be happening.

[gilmillasseau]

Sorry I though was on restart, it's when I do docker-compose up -d --build

[chrisleekr]

Even that command, should not lose any customised configuration as that configuration is stored in the mongodb. The whole point of using the persistent database is to not lose configurations & last buy price.

Some other things must be going on. Can you take a video of that?

[gilmillasseau]

Ok so I was able to reproduce:

• Change Maximum purchase amount to 20 on pair config
• Change global config candle interval to 30m (was 1h)
• Hit button Apply to all symbols
• All Maximum purchase amount configs are back to 100 even the ones I customized

Is this the expected behaviour? Probably I am using this incorrectly.

[chrisleekr]

Yes, as the modal mentioned, it will remove customised symbol configurations if you click "Apply to all symbols".

[gilmillasseau]

Ok, makes sense, I am testing this tool and sometimes I just want to change global configuration after changing the maxPurchaseAmount for each config, can I hardcode somewhere the default to be different than 100?

[chrisleekr]

Hmmmmmmmmmmmmmmm....

Maybe I should revert the max purchase amount field and give the option to set dynamically calculated. @GrigorovskyA also confused about the max purchase amount like you.

Let me think about it.

[gilmillasseau]

Think this will happen often when you are first trying this bot and trying several configs, I can now understand it's only when you want to apply a global config to all pairs that resets the value maxPurchaseAmount to 100.

Let me know if you need more help testing this ;)

[GrigorovskyA]

Yes, this is the case - I have not yet figured out how it would be possible to implement the percentage.

I thought aside that each pair has a name - Coin-Bridge. eg: ethUSDT, wavesBNB,algoBTC And for each bridge, it would be possible to collect information and thus we can get an approximate current balance of the bridge coins on accounts. Bot could to split coinpair - coin-bridge - And in the global configuration, add param max bridge for each bridgecoin from used pairs list - the amount of the maximum price

[chrisleekr]

@GrigorovskyA Right, so are you suggesting, if I put coins like BTCUSDT, ETHBNB, ETHBTC, then there will be three fields for each quote assets?

• USDT: 100
• BNB: 0.1
• BTC: 0.001

This may work, I think?

[GrigorovskyA]

I think this is a good option. What do you think? And I like the idea, of course, to set limits on percentages.

[chrisleekr]

I am working on it. I will need some refactoring for implementing this.

[GrigorovskyA]

@chrisleekr it's your current bot settings? and which profit of it?

I think it would be cool to raise a discord server(for exmaple) so that people can change their profits and observations. and fumble around useful results and scripts with lists of volatile coins.

[gilmillasseau]

@chrisleekr not related but I will take advantage of this thread to ask something regarding buy signal see this screenshot:

Config

If the price was at 556 at 20:12 how bot created an order to buy when price is >= 563?

[GrigorovskyA]

@gilmillasseau read about https://github.com/chrisleekr/binance-trading-bot#buy-scenario 556+1.21% ~ 563

[chrisleekr]

@GrigorovskyA

@chrisleekr it's your current bot settings? and which profit of it?

No, that is my test bot configuration for development.

My live bot configuration is different. I also still look for a working configuration; however, my personal opinion is, there is no single working configuration. It should be different per coin and market trend. And very importantly, choosing a good coin. Last time, I traded XRPDOWN/LTCDOWN and lost money. Do not trade DOWN leverage token!

I think it would be cool to raise a discord server(for example) so that people can change their profits and observations. and fumble around useful results and scripts with lists of volatile coins.

I don't use Discord and don't have much time to involve to chat all the time. Sorry.

[chrisleekr]

@GrigorovskyA @gilmillasseau

Guys, I have reverted the max purchase amount back to the global configuration. See the comment - https://github.com/chrisleekr/binance-trading-bot/pull/77#issuecomment-830126744

[chrisleekr]

@gilmillasseau I think this issue can be closed as I delivered the global configuration back and explained about % buy.

[gilmillasseau]

@chrisleekr I am testing since yesterday, everything is working fine 👍 Nice work.