chrisleekr / binance-trading-bot

Automated Binance trading bot - Trade multiple cryptocurrencies. Buy low/sell high with Grid Trading. Integrated with TradingView technical analysis
MIT License
5.06k stars 1.1k forks source link

New features and enhancements by myself. #235

Open pedrohusky opened 3 years ago

pedrohusky commented 3 years ago

Hi @chrisleekr.

Has been some time that I last spoke here. I was busy, but I made some beautiful enhancements to the bot.

I think I did the tests about remove-last-buy-price-threshold. But somehow even installing everyhing, the tests still fail to me (it don't even start).

Can you please, test my fork (branch telegram-language-lastbuy)?

I'm thinking of split my changes (just multilanguage won't be possible) to make it easier to you verify my code.

1 - I did not hurt anything at the core of the bot. Just changed some strings here and there, added an new indicator that I call it Husky Indicator (I have some screenshot's about my trades with it).

2 - The new indicator now makes the bot follows a dip and buys at the lowest price AFTER the dip.

3 - The new indicator now makes the bot follows the uptrend and sell with a profit HIGHER than defined at sell trigger.

4 - Multilanguage. Now Bot supports en, es, vi, pt, nl.

5 - The bot now stakes the coins. Ex: If you set your sell trigger to 0,5%, the bot will only sell 99,5% of the amount it had bought. It is an option to disable/enable.

6 - There's a option to make the bot sell at market order when trending is going down and profit is higher than sell price (sell at market order to maximize profits in an falling trend).

7 - It now just sells the amount it bought, before my enhancement it would sell all free balance available.

8 - I'm working at a backtest. Need help with it though.

9 - I changed a little the bot theme. Now it supports both light and dark mode just clicking a button. Need help changing its icon.

10 - Frontend variable boxe's now display an percentage of the value you put. It shows also the quote asset.

11 - There's an Average Price field now. Currently it is only cosmetic, in the future will be used by the bot to make more than one purchase at a time per symbol. Then it will average the price. It will be an option though.

12 - And more that I don't remember now.

Can I ask your discord contact? For future talks, if possible.

Thanks for this amazing bot, Chris. I like your coding skills, and your code is very clean. I'm happy to help with it.

@edit

A few screenshots of the new theme. I hope you approve it. Need some help with the color of the tiny icons.

Captura de Tela (129) Captura de Tela (130) Captura de Tela (131) Captura de Tela (132) Captura de Tela (133) Captura de Tela (134) Captura de Tela (135) Captura de Tela (136)

Some trades with Husky Indicator:

Captura de Tela (72) Captura de Tela (74) Captura de Tela (76) Captura de Tela (79) Captura de Tela (81) Captura de Tela (82) Captura de Tela (83) Captura de Tela (85) Captura de Tela (86)

ALL THOSE TRADES WERE MADE USING THE HUSKY INDICATOR

Its all in pt-br but the values are in the same place.

NOTE: Backtest button shouldn't be there. I'm testing it...

chrisleekr commented 3 years ago

Hey @pedrohusky

Thanks for your contributions. All looks good.

Sorry for the late reply. I have been extremely busy recently.

Can you please, test my fork (branch telegram-language-lastbuy)?

Yeah sure, I will take a look and let me write some test code.

For the other changes, yes, please make PR with the smallest changes possible.

Can I ask your discord contact? For future talks, if possible.

Sorry, I don't have a discord account. :)

habibalkhabbaz commented 3 years ago

@pedrohusky It seems awesome enhancements. I am interested to look at the husky indicator and how it differs from the current bot strategy. May I have your discord?

pedrohusky commented 3 years ago

@pedrohusky It seems awesome enhancements. I am interested to look at the husky indicator and how it differs from the current bot strategy. May I have your discord?

Sure. I'm mostly active in the discord channel of this bot. It is pinned at issues. :)

gotbase commented 3 years ago

your features is nice, may i have your discord ?

pedrohusky commented 3 years ago

your features is nice, may i have your discord ?

Thanks.

pedrohusky#9119

StreetHunter189 commented 3 years ago

Hi Pedro,

Your features are nice. I am unable to join you on discord. It is saying invitation expired

thesam1545 commented 3 years ago

I have watched a video about an expert trading guy, who talked about the best indicators that should be used to buy/sell in the crypto world: https://www.youtube.com/watch?v=33lGueGyrc4&t=3s&ab_channel=TheSecretMindset

He claims that there are 4 indicators that work in different areas and are very powerful when working together: VWAP, Heikin-Ashi candles, MACD and Bollinger Bands

This bot is very well made, but I have not made meaningful profits with the Trailing Stop Orders... I have very little coding knowledge, but I would like to see these indicators applied in this bot. Is it to difficult to implement this indicators in this bot?

PS: Sou português de Portugal amigo BR ;)

eth-man commented 3 years ago

Hi @pedrohusky thank you for the all the great features ! can you suggest how to use your backtester ? i think this feature is highly usable.

pedrohusky commented 3 years ago

Hi @pedrohusky thank you for the all the great features ! can you suggest how to use your backtester ? i think this feature is highly usable.

Hello. I guess there is a file called determine-backtest.js there.

This file contains the foundation for a backtest.

At the time, I was stuck at parsing the .CSV after downloading and extracting it.

It downloads and extracts the zip's related to the days you choose.

Download is done correctly. Extracting too. Just when loading CSV that wasn't working.

Oh, and it needs to be re-integrated into the frontend.

The foundation is really there, just need some adjusts. Let me know if you want some help. I'm active at discord, in the bot channel too. pedrohusky#9119

:)