chrisleekr / binance-trading-bot

Automated Binance trading bot - Trade multiple cryptocurrencies. Buy low/sell high with Grid Trading. Integrated with TradingView technical analysis
MIT License
5.05k stars 1.09k forks source link

#248 Order was not been recorded on grid feature #252

Closed elvishp2006 closed 3 years ago

elvishp2006 commented 3 years ago

Version

v0.0.73 (1f01589)

Description

The bot executed two buy grids at binance, but it's showing that was executed only the first one

To Reproduce

Expected Behaviours

Record the executed grids

Screenshots

image image

Additional context

chrisleekr commented 3 years ago

I assume you have slack integration. Can you go through and find messages for the order filled at 2021-07-30 06:29:29

What I expect to see is

MATICUSDT Buy Action Grid Trade #2 (xxxx): STOP_LOSS_LIMIT
MATICUSDT Buy Action Grid Trade #2 Result (xxxx): STOP_LOSS_LIMIT
MATICUSDT Action (xxxxx): Confirmed buy order

MATICUSDT BUY Grid Trade #2 Order Filled (xxxx): STOP_LOSS_LIMIT
or
MATICUSDT BUY Grid Trade #2 Order Removed (xxxx): STOP_LOSS_LIMIT
chrisleekr commented 3 years ago

Oh wait, your git SHA is different. Were you build from the PR?

Running Version: v0.0.73 (a7d650b)

elvishp2006 commented 3 years ago

@chrisleekr I have been build the image from master after you release the new version

elvishp2006 commented 3 years ago

MATICUSDT Action (09:28:09.359): Removed last buy price

MATICUSDT Buy Action Grid Trade #1 (09:28:11.215): STOP_LOSS_LIMIT

MATICUSDT Buy Action Grid Trade #1 Result (09:28:11.711): STOP_LOSS_LIMIT

MATICUSDT Action (09:28:12.386): Confirmed buy order

MATICUSDT Buy Action Grid Trade #1 (09:28:13.778): STOP_LOSS_LIMIT

MATICUSDT Buy Action Grid Trade #1 Result (09:28:14.256): STOP_LOSS_LIMIT

MATICUSDT Action (09:28:15.400): Confirmed buy order

MATICUSDT Buy Action Grid Trade #1 (09:28:17.492): STOP_LOSS_LIMIT

MATICUSDT Buy Action Grid Trade #1 Result (09:28:17.972): STOP_LOSS_LIMIT

MATICUSDT Action (09:28:18.398): Confirmed buy order

MATICUSDT Buy Action Grid Trade #1 (09:29:15.493): STOP_LOSS_LIMIT

MATICUSDT Buy Action Grid Trade #1 Result (09:29:15.975): STOP_LOSS_LIMIT

MATICUSDT Action (09:29:16.433): Confirmed buy order

MATICUSDT Buy Action Grid Trade #1 (09:29:25.484): STOP_LOSS_LIMIT

MATICUSDT Buy Action Grid Trade #1 Result (09:29:26.283): STOP_LOSS_LIMIT

MATICUSDT Action (09:29:27.392): Confirmed buy order

MATICUSDT Buy Action Grid Trade #1 (09:29:29.541): STOP_LOSS_LIMIT

MATICUSDT Buy Action Grid Trade #1 Result (09:29:30.303): STOP_LOSS_LIMIT

MATICUSDT Action (09:29:31.401): Confirmed buy order

MATICUSDT Last buy price Updated (09:30:35.267): STOP_LOSS_LIMIT

MATICUSDT BUY Grid Trade #1 Order Filled (09:30:35.282): STOP_LOSS_LIMIT

chrisleekr commented 3 years ago

Ok from the Slack message, I can see the order filled at 06:29:29 is not grid trade #2, it was grid trade #1.

Now the question is why... ah, I got it.

MATICUSDT Action (09:28:09.359): Removed last buy price

Message: Balance is less than the last buy price remove threshold. Delete last buy price.
{
 "lastBuyPrice": 1.0183,
 "baseAssetQuantity": 9.9,
 "currentPrice": 1,
 "minNotional": "10.00000000",
 "openOrders": []
}
Current API Usage: 93

When remove the last buy price, it removes previous grid trade history.

Now, since you only trade $10 worth, the bot will remove the last buy price if it is not worth more than $10.

To prevent that, set the last buy price removal threshold to like 5

image

If you set that, even if the coin is not worth the minimum notional value, it won't remove the last buy price.

elvishp2006 commented 3 years ago

Thanks @chrisleekr, I will set a lower value for this field :)

chrisleekr commented 3 years ago

Thanks to @pedrohusky who developed this feature!

Close the issue if your issue is resolved!

elvishp2006 commented 3 years ago

Thanks also @pedrohusky :D