search

chrisleekr / binance-trading-bot

Automated Binance trading bot - Trade multiple cryptocurrencies. Buy low/sell high with Grid Trading. Integrated with TradingView technical analysis
MIT License
5k stars 1.09k forks source link

feat: Automatic conversion to BNB using feature "Convert to small BNB assets" #317

Open ilbuonmarcio opened 3 years ago

ilbuonmarcio commented 3 years ago

Is your proposal related to a problem?

Being the tired human being I am, I usually forget to convert small useless remaining coins to BNB.

Describe the solution you'd like

Can we make a feature, configurable in the global configuration, and only handling coin pairs handled by the bot exclusively, and also lower than a certain USDT price and currently not in a trade nor with the last buy price set, to automagically convert to BNB every now and then using the feature already provided with the bot, but with a cron instead?

It should be default to disabled, and you need to explicitly enable it to get the desired effect.

Additional context

Me and @pedrohusky are currently discussing about it on Discord chat and getting suggestions and possible problems would be useful.

It should be not a big of a development effort on our side, but that can be a fine improvement to the bot automation in general, which I especially prefer :)

chrisleekr commented 3 years ago

Oh, interesting.

But there are some issues with automating that.

If you are trading a small amount of quote assets like 10 USDT, then the coin is eligible for the dust transfer, which I don't want. The calculation for dust transfer is as below:

Based on the Binance doc - https://academy.binance.com/en/articles/converting-dust-on-binance - you can execute dust transfer if the value is less than 0.001BTC, which I just found this is updated. Last time when I checked that document, it was 0.0003BTC.

Anyway, for small traders, this automation can cause unexpected results.

ilbuonmarcio commented 3 years ago

We were thinking about setting a maximum threshold for each quote, like 5 for USDT pairs, to handle this.

chrisleekr commented 3 years ago

Right, that should resolve the issue. :+1:

As you can see from the official doc, it should be calculated against BTC to determine dust-transferable. So if you want to calculate with USDT (quote assets), then it may not correct way to achieve it.

ilbuonmarcio commented 3 years ago

This is fine with me 💪🏻