search

chrisleekr / binance-trading-bot

Automated Binance trading bot - Trade multiple cryptocurrencies. Buy low/sell high with Grid Trading. Integrated with TradingView technical analysis
MIT License
5k stars 1.09k forks source link

Logging precedes action #559

Open uhliksk opened 1 year ago

uhliksk commented 1 year ago

I think it is bad idea to log action as successful before it is actually done. This can result in action is logged but actually not executed successfully which can lead to false sense of everything has been done correctly when reviewing the logs while the action actually failed.

https://github.com/chrisleekr/binance-trading-bot/blob/209d2e081ec63259c0c0b6fc1eb3606d13bd8786/app/cronjob/trailingTradeHelper/configuration.js#L393-L395

chrisleekr commented 1 year ago

Yap, I agree.

I will go through the code and fix it when I get time. Don't have much time at this point.