search

chrisleekr / binance-trading-bot

Automated Binance trading bot - Trade multiple cryptocurrencies. Buy low/sell high with Grid Trading. Integrated with TradingView technical analysis
MIT License
4.96k stars 1.08k forks source link

fix: queue job execution timeout #620

Open uhliksk opened 1 year ago

uhliksk commented 1 year ago

Description

Moved the timeout processing into a queue to end the job correctly if it's duration is over the timeout.

Related Issue

594

Motivation and Context

Will prevent non-deterministic behavior of the job queue.

How Has This Been Tested?

This PR is just a proposal for the solution. I'm sorry, I haven't had time to test it.

Screenshots (if appropriate):

chrisleekr commented 1 year ago

Hey @uhliksk

Thank you for trying to fix it up.

However, I was not able to test it out since there is no test. I can add tests, but I hope you can verify the change is fixing the issue?

uhliksk commented 1 year ago

Hi @chrisleekr

Thank you for a ping. I'll try to reserve some spare time to test and tune a solution this week.