search

chrisleekr / binance-trading-bot

Automated Binance trading bot - Trade multiple cryptocurrencies. Buy low/sell high with Grid Trading. Integrated with TradingView technical analysis
MIT License
4.96k stars 1.08k forks source link

Config caching changes until reload of website. #631

Open dasbts opened 1 year ago

dasbts commented 1 year ago

Version

v0.0.98 (commit is unspecified as I build local docker image)

Description

Changing the config, then pressing close instead of save, and then reopening it appears as saved even when it is not, until the user reloads the website and opens the config again to see that the change was reverted.

To Reproduce

  1. Open the config on the top right of the website with the cogwheel button.
  2. Enter a symbol that you don't have in the list at the moment and click it so it appears in the list of symbols.
  3. Scroll to the bottom of the config and press close.
  4. Open the config on the top right again and see the change.
  5. Duplicate the tab in your browser so you have two of the website open at once.
  6. Open the config on the new duplicated tab. The change is gone, but it appears in the already opened tab.

Expected Behaviours

Clear the changes when pressing close (probably want a message if there was a change if the user really doesn't want to save the changes).