Open rando128 opened 4 months ago
I came across this small but nasty error while reusing @habibalkhabbaz ATH candles implementation for a new feature.
The loop over the symbols doesn't loop at all if buyATHRestrictionEnabled is not true for all symbols. The return statement should be a continue statement: https://github.com/chrisleekr/binance-trading-bot/blob/a9e50e8ab8636a00c892b087a80501fa6d636721/app/binance/ath-candles.js#L39
symbols
buyATHRestrictionEnabled
return
continue
Unfortunately I can't submit a PR now since my codeline is too far from master.
I came across this small but nasty error while reusing @habibalkhabbaz ATH candles implementation for a new feature.
The loop over the
symbolsdoesn't loop at all ifbuyATHRestrictionEnabledis not true for all symbols. Thereturnstatement should be acontinuestatement: https://github.com/chrisleekr/binance-trading-bot/blob/a9e50e8ab8636a00c892b087a80501fa6d636721/app/binance/ath-candles.js#L39Unfortunately I can't submit a PR now since my codeline is too far from master.