search

chrislgarry / Apollo-11

Original Apollo 11 Guidance Computer (AGC) source code for the command and lunar modules.
Other
57.5k stars 6.85k forks source link

Proof INTERRUPT_LEAD_INS #597

Closed wopian closed 3 years ago

wopian commented 4 years ago

Proof read transcribed code of INTERRUPT_LEAD_INS against scans

Lines: 117 Page: 0153—0154 (2)

Reduced quality scans can be found here

Nabeelhassan commented 3 years ago

I am taking this task. Will create a pull request shortly.

Nabeelhassan commented 3 years ago

why did you remove the hacktoberfest label @wopian ???

wopian commented 3 years ago

why did you remove the hacktoberfest label @wopian ???

Because it's a tag temporarily added alongside Good First Issue (on issues with Help Wanted and either Tiny or Small labels).

These labels are there to guide potential contributors to issues they will manage to complete, instead of going in blind to a huge or bigger issue with 40+ pages and getting overwhelmed. The two biggest size labels are not something that can be reasonably proofed and reviewed within a month and do not have Good First Issue or hacktoberfest labels.

This issue now has a PR that proofs it and no longer needs the Helped Wanted label, which makes the Good First Issue and hacktoberfest labels unneeded.

The hacktoberfest label has no effect on Hacktoberfest eligibility. The repository has the hacktoberfest topic and all approved or merged PRs are eligble. The only labels Hactoberfest cares about are hacktoberfest-accepted (if the repository hasn't opted in), spam or invalid on PRs.

image

Nabeelhassan commented 3 years ago

Ok, thanks for the clarification.