chrislgarry / Apollo-11

Original Apollo 11 Guidance Computer (AGC) source code for the command and lunar modules.
Other
57.5k stars 6.85k forks source link

Improved french translation of the contributing file #847

Closed Aur36 closed 2 years ago

Aur36 commented 2 years ago

Hello, could you please add the label "hacktoberfest-accepted" to this PR ? Many thanks !

wopian commented 2 years ago

It shouldn't need the label as it was merged

Aur36 commented 2 years ago

It is strange because the hacktoberfest website says "Pull request not yet accepted" about this commit, so I wondered if the label could unlock the situation

wopian commented 2 years ago

Unfortunately PRs needed to be merged or accepted (review/label) before 1st November, which this wasn't (Seen, checked and merged on the 1st at 11am).

The state of non-maturing PRs is frozen, so adding the label now won't start the 14 day maturing period.

Aur36 commented 2 years ago

That would explain, thank you for the explanation.