chrislicodes / obsidian-chess-study

A chess study helper and PGN viewer/editor for Obsidian.
GNU General Public License v3.0
32 stars 4 forks source link

The coordinate axis is not visible. Add more features #9

Open ntd103 opened 7 months ago

ntd103 commented 7 months ago

I don't see the coordinate axis of the chessboard as shown in the illustrated gif in your readme file. Can you add interaction with arrow keys?

I really like this plugin🥰🥰, please continue developing it. Thank you very much.

ntd103 commented 7 months ago

Edit PGN directly. I don't see this in your roadmap.

What do you think about this feature? Provide the ability to edit PGN (including variations) after importing, through a text editing method. This includes adding and deleting PGN, of course.

Is it feasible to implement this?

latenitecoding commented 7 months ago

I don't see the coordinate axis of the chessboard as shown in the illustrated gif in your readme file. Can you add interaction with arrow keys?

I really like this plugin🥰🥰, please continue developing it. Thank you very much.

This plugin does not render the chessboard itself. It instead relies on the ChessgroundAPI released by Lichess to do that. I turned on coordinates within the ChessgroundAPI, and they did not render within the chessboard in Obsidian. My guess is that we need to check the version of the ChessgroundAPI. If we can't get its coordinates option to work, then we're out of luck on this one.

latenitecoding commented 7 months ago

Edit PGN directly. I don't see this in your roadmap.

What do you think about this feature? Provide the ability to edit PGN (including variations) after importing, through a text editing method. This includes adding and deleting PGN, of course.

Is it feasible to implement this?

I have a few PRs coming down the road that allows this indirectly. One PR (which has already been integrated) allows for a user to undo moves. This would allow you to redact any number of moves started from the last move of a line. A second PR that's coming is to export the PGN. You would be able to export the PGN and then modify it before reimporting. I've already tested this PR and it works. The last PR allows you to annotate moves, which is a common reason why people want to be able to edit the PGN. I've tested that one as well and it works.

Allowing users to edit the PGN directly of an already created chess-study block is risky. We have no way to prevent the user from crashing the block if they type in something wrong. Using indirect methods takes a little extra time but provides a much better experience. I'd love to get more feedback once we can get these features out though.

chrislicodes commented 7 months ago

Hm, the coordinates not being rendered is interesting and sounds like a CSS issue, are you using a theme @youshouldseemeinacrown?

image

chrislicodes commented 7 months ago

Lets check again after merge of the additional features of @latenitecoding if this still is needed - arrow key control would be nice and accessible - but I am not sure if this works well inside a markdown post process - but interesting question

chrislicodes commented 6 months ago

Hey, did you have a chance to try the new version?

ntd103 commented 6 months ago

@chrislicodes @latenitecoding I sincerely apologize for this delayed response. Please accept my deepest apologies for this rudeness. Your replies were sent right during the Tet holiday in Vietnam. Honestly, I've had exhausting days dealing with numerous family tasks. In other words, I completely forgot about my laptop for a whole month during Tet 🤦‍♂️🤦‍♂️ And that's how I missed the notification about your reply. hix hix

chrislicodes commented 6 months ago

No worries!

ntd103 commented 6 months ago

Lets check again after merge of the additional features of @latenitecoding if this still is needed - arrow key control would be nice and accessible - but I am not sure if this works well inside a markdown post process - but interesting question

Thank you, @chrislicodes and @latenitecoding . It has been working wonderfully. The plugin has saved me a lot of effort and time when using a combination of Obsidian and Lichess. I look forward to the exciting features that you will update in the future. 😍😍