chrislim2888 / IP2Location-C-Library

IP2Location C library enables the user to find the country, region, city, coordinates, zip code, time zone, ISP, domain name, connection type, area code, weather station code, weather station name, mobile, usage types, etc that any IP address or hostname originates from.
https://www.ip2location.com
MIT License
61 stars 30 forks source link

IP2Location-Lite-data RPM and "ip2locationlookup" #29

Closed pbiering closed 3 years ago

pbiering commented 4 years ago

this is related to https://github.com/chrislim2888/IP2Location-C-Library/issues/27

would it make sense to request similar to GeoIP-GeoLite-data an independent IP2Location-Lite-data RPM (dedicated package) -> should get regular updates

or should I create only a subpackage in the IP2Location RPM named IP2Location-data-sample which get only update from release to release (if ever) for initial testing.

Which leads me also to the request of "ip2locationlookup" (similar to geoiplookup), which uses the library and default or provided BIN files to check whether all is working fine.

chrislim2888 commented 4 years ago

We prefer a subpackage that updated from release to release. Users should sign up the latest database in our web site https://lite.ip2location.com

pbiering commented 4 years ago

ok, will extend spec on FedoraBuildSystem next.

Can I expect the "ip2locationlookup" tool until 8.0.10 or will this arrive in a later stage?

Background: I plan not to push 8.0.9 to EL-stable but leave intermediate versions there for further testing and push then 8.0.10 which should be not so far away after all the PRs I've made (but wait at least until the data sub-RPM changes are submitted to upstream).

chrislim2888 commented 4 years ago

Can you please release the version first? I think it may take a while before we can have the application ready.

pbiering commented 4 years ago

Sneak preview of more or less latest master + new subpackage "IP2Location-data-sample" now in fc34/rawhide, one can now check and test (rebuild of SRPMS on other favorite Fedora/EL version should also work):

https://koji.fedoraproject.org/koji/buildinfo?buildID=1608876

a change of the subpackage name can be still done

chrislim2888 commented 4 years ago

No problem, we are good with the subpackage name.

pbiering commented 4 years ago

please check and test latest builds (8.0.9-9)

https://koji.fedoraproject.org/koji/packageinfo?packageID=32132

chrislim2888 commented 4 years ago

We are going to build the command script. Can we use "ip2location" as the BIN name instead of "ip2locationlookup"? thanks.

pbiering commented 4 years ago

another option would be "ip2lookup", but I can also softlink to support multiple names

pbiering commented 4 years ago

8.0.9 has reached stable state for Fedora: https://src.fedoraproject.org/rpms/IP2Location - in 7 days also EL will follow

ip2location commented 3 years ago

We have developed ip2locationlookup and it's available at https://github.com/ip2location/ip2location-lookup/